Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(docs): rsdoctor add the note for CssExtractRspackPlugin #8087

Merged
merged 2 commits into from
Oct 17, 2024
Merged

chore(docs): rsdoctor add the note for CssExtractRspackPlugin #8087

merged 2 commits into from
Oct 17, 2024

Conversation

easy1090
Copy link
Collaborator

@easy1090 easy1090 commented Oct 11, 2024 •
edited
Loading

Summary

[Docs] Rsdoctor add the note for CssExtractRspackPlugin

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify Netlify
Copy link

netlify bot commented Oct 11, 2024 •
edited
Loading

✅ Deploy Preview for rspack ready!

Name Link
🔨 Latest commit bbd3f90
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/6710d7eeb2c76d00082155e7
😎 Deploy Preview https://deploy-preview-8087--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

chenjiahan
chenjiahan reviewed Oct 11, 2024
View reviewed changes
Copy link
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we move this note to the Rsdoctor documentation?

@easy1090
Copy link
Collaborator Author

easy1090 commented Oct 11, 2024 •
edited
Loading

Should we move this note to the Rsdoctor documentation?

@chenjiahan
Did you mean moving "Use Rsdoctor" to Rspack's website or to Rsdoctor's website?

I'll also add it to Rsdoctor's website. If you were referring to the Rspack website, I think this note should be placed near the loader profile documentation for Rsdoctor.

@chenjiahan
Copy link
Member

chenjiahan commented Oct 11, 2024 •
edited
Loading

I mean move "this note" to the Rsdoctor website.

If Rsdoctor already provides this note, I don't recommend maintaining two copies of the same content. You can just link to the Rsdoctor documentation.

Considering that the Rsbuild documentation also has a "Use Rsdoctor" section, it is unreasonable to maintain multiple copies of the same content.

@easy1090 easy1090 force-pushed the chore/fix-rsdoctor-docs branch 2 times, most recently from fa02da1 to da31894 Compare October 12, 2024 10:19
chenjiahan
chenjiahan previously approved these changes Oct 16, 2024
View reviewed changes
@chenjiahan
Copy link
Member

CI broken:

image

@easy1090
chore(docs): rsdoctor add the note for CssExtractRspackPlugin
19fc1c4 
chore(docs): rsdoctor add the note for CssExtractRspackPlugin

chore(docs): fix rsdoctor docs
@easy1090
Copy link
Collaborator Author

CI broken:

image

@chenjiahan this is be ok~

@easy1090 easy1090 enabled auto-merge (squash) October 17, 2024 09:16
@easy1090 easy1090 merged commit 0017a68 into main Oct 17, 2024
28 checks passed
@easy1090 easy1090 deleted the chore/fix-rsdoctor-docs branch October 17, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenjiahan chenjiahan chenjiahan approved these changes

@JSerFeng JSerFeng Awaiting requested review from JSerFeng

@jerrykingxyz jerrykingxyz Awaiting requested review from jerrykingxyz

Assignees

@easy1090 easy1090

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@easy1090 @chenjiahan