Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: collect rebuild modules mutations in make #8196

Merged
merged 2 commits into from
Oct 23, 2024
Merged

refactor: collect rebuild modules mutations in make #8196

merged 2 commits into from
Oct 23, 2024

Conversation

ahabhgk
Copy link
Collaborator

@ahabhgk ahabhgk commented Oct 22, 2024

Summary

  • remove unaffected stuff
  • collect rebuild modules in make, instead of an independent globle effect phase

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify Netlify
Copy link

netlify bot commented Oct 22, 2024 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit ff856ba
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/6717a3936059080008d10296

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Oct 22, 2024
@ahabhgk ahabhgk requested a review from JSerFeng October 22, 2024 13:02
@ahabhgk ahabhgk changed the title refactor: remove unaffected stuff and collect rebuild modules in make refactor: collect rebuild modules in make Oct 22, 2024
@ahabhgk ahabhgk changed the title refactor: collect rebuild modules in make refactor: collect rebuild modules mutations in make Oct 22, 2024
@ahabhgk ahabhgk enabled auto-merge (squash) October 22, 2024 13:08
@ahabhgk ahabhgk merged commit f3f8302 into main Oct 23, 2024
33 checks passed
@ahabhgk ahabhgk deleted the refactor-inc-remove-unaffected-stuff branch October 23, 2024 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JSerFeng JSerFeng JSerFeng approved these changes

@jerrykingxyz jerrykingxyz Awaiting requested review from jerrykingxyz jerrykingxyz is a code owner

Assignees

@ahabhgk ahabhgk

Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahabhgk @JSerFeng