Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: add JSDoc to improve config.wath types #8201

Merged
merged 1 commit into from
Oct 23, 2024
Merged

refactor: add JSDoc to improve config.wath types #8201

merged 1 commit into from
Oct 23, 2024

Conversation

GiveMe-A-Name
Copy link
Member

Summary

Zod types system is not easy to understand by user.

We tend use raw ts provider intellisense and jsDoc for user in ide.

  • Add type & JSDoc for config.watch
  • Add type & JSDoc for config.watchOptions

See #4241 more detail.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify Netlify
Copy link

netlify bot commented Oct 23, 2024 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit bc535b8
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/67185fd9be959100088808ce

@GiveMe-A-Name GiveMe-A-Name mentioned this pull request Oct 23, 2024
Open
@chenjiahan chenjiahan merged commit 5ee60b0 into main Oct 23, 2024
34 checks passed
@chenjiahan chenjiahan deleted the refactor/configuration-watch branch October 23, 2024 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenjiahan chenjiahan chenjiahan approved these changes

@ahabhgk ahabhgk ahabhgk approved these changes

Assignees

@GiveMe-A-Name GiveMe-A-Name

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GiveMe-A-Name @chenjiahan @ahabhgk