Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: add JSDoc to improve config.devServer type #8213

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

refactor: add JSDoc to improve config.devServer type #8213

wants to merge 3 commits into from

Conversation

GiveMe-A-Name
Copy link
Member

Summary

Zod types system is not easy to understand by user.

We tend use raw ts provider intellisense and jsDoc for user in ide.

  • Add JSDoc for config.devServer

See #4241 more detail.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify Netlify
Copy link

netlify bot commented Oct 24, 2024 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 8fe1f19
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/671a4333c8b61c00085ed35f

@GiveMe-A-Name GiveMe-A-Name mentioned this pull request Oct 24, 2024
Open
@GiveMe-A-Name GiveMe-A-Name enabled auto-merge (squash) October 24, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenjiahan chenjiahan chenjiahan approved these changes

@ahabhgk ahabhgk Awaiting requested review from ahabhgk

Assignees

@GiveMe-A-Name GiveMe-A-Name

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GiveMe-A-Name @chenjiahan