Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(rust): improve replace_all_placeholder #9289

Merged

Conversation

shulaoda
Copy link
Collaborator

Summary

  • To avoid incorrect matches, prevent matching [ext] as [extname].
  • Ensure placeholders like [hash:] or [hash:o] are not matched.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Feb 13, 2025

Deploy Preview for rspack canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit ddc37ee
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/67adfe4d80a536000858d32a

@shulaoda shulaoda requested a review from h-a-n-a February 13, 2025 14:26
Copy link

codspeed-hq bot commented Feb 13, 2025

CodSpeed Performance Report

Merging #9289 will not alter performance

Comparing shulaoda:refactor/improve-replace-all-placeholder (ddc37ee) with main (05524cd)

🎉 Hooray! codspeed-rust just leveled up to 2.7.2!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

✅ 6 untouched benchmarks

@h-a-n-a h-a-n-a merged commit 7d4c6c2 into web-infra-dev:main Feb 14, 2025
34 checks passed
@shulaoda shulaoda deleted the refactor/improve-replace-all-placeholder branch February 14, 2025 06:11
h-a-n-a added a commit that referenced this pull request Feb 14, 2025
chenjiahan pushed a commit that referenced this pull request Feb 15, 2025
…9304)

Revert "refactor(rust): improve `replace_all_placeholder` (#9289)"

This reverts commit 7d4c6c2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants