Skip to content

Commit

Permalink
Fetch Metadata: deprecate nested-navigate mode.
Browse files Browse the repository at this point in the history
As discussed in
w3c/webappsec-fetch-metadata#45,

We have decided to shift the model around nested navigations from
exposure via the request's `mode` to its `destination`. This patch
shift the `nested-navigate` mode to two parts:
 - `navigate` for frame and iframe.
 - `no-cors` for object.

Change-Id: I09a2be6b41547f6eeb1e308416234a40f0c9b5b3
  • Loading branch information
iVanlIsh authored and chromium-wpt-export-bot committed Oct 25, 2019
1 parent 813f140 commit 0f40fe7
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 10 deletions.
12 changes: 6 additions & 6 deletions fetch/metadata/iframe.tentative.https.sub.html
Original file line number Diff line number Diff line change
Expand Up @@ -44,36 +44,36 @@
create_test("{{host}}:{{ports[https][0]}}", FORCED, {
"site": "same-origin",
"user": "",
"mode": "nested-navigate"
"mode": "navigate"
});

create_test("{{hosts[][www]}}:{{ports[https][0]}}", FORCED, {
"site": "same-site",
"user": "",
"mode": "nested-navigate"
"mode": "navigate"
});

create_test("{{hosts[alt][www]}}:{{ports[https][0]}}", FORCED, {
"site": "cross-site",
"user": "",
"mode": "nested-navigate"
"mode": "navigate"
});

create_test("{{host}}:{{ports[https][0]}}", USER, {
"site": "same-origin",
"user": "?1",
"mode": "nested-navigate"
"mode": "navigate"
});

create_test("{{hosts[][www]}}:{{ports[https][0]}}", USER, {
"site": "same-site",
"user": "?1",
"mode": "nested-navigate"
"mode": "navigate"
});

create_test("{{hosts[alt][www]}}:{{ports[https][0]}}", USER, {
"site": "cross-site",
"user": "?1",
"mode": "nested-navigate"
"mode": "navigate"
});
</script>
2 changes: 1 addition & 1 deletion fetch/metadata/iframe.tentative.sub.html
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@
assert_header_equals(e.data, {
"site": "cross-site",
"user": "",
"mode": "nested-navigate",
"mode": "navigate",
});
t.done();
}));
Expand Down
6 changes: 3 additions & 3 deletions fetch/metadata/portal.tentative.https.sub.html
Original file line number Diff line number Diff line change
Expand Up @@ -27,18 +27,18 @@
create_test("{{host}}:{{ports[https][0]}}", {
"site": "same-origin",
"user": "",
"mode": "nested-navigate"
"mode": "navigate"
});

create_test("{{hosts[][www]}}:{{ports[https][0]}}", {
"site": "same-site",
"user": "",
"mode": "nested-navigate"
"mode": "navigate"
});

create_test("{{hosts[alt][www]}}:{{ports[https][0]}}", {
"site": "cross-site",
"user": "",
"mode": "nested-navigate"
"mode": "navigate"
});
</script>

0 comments on commit 0f40fe7

Please sign in to comment.