Skip to content

Commit

Permalink
De-flake customizable select reftests
Browse files Browse the repository at this point in the history
Most of the flakes are happening because the appearance property is
changed while the picker is open which closes the picker. Adding some
rAFs will hopefully prevent computed style from changing while the
picker is open.

Fixed: 383825172, 384363006, 384401571, 384198071, 383884638
Change-Id: Ia88a2eef5fd5d4db8191bbb24058fbf05ee497b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6120129
Reviewed-by: Di Zhang <[email protected]>
Commit-Queue: Joey Arhar <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1400575}
  • Loading branch information
josepharhar authored and chromium-wpt-export-bot committed Dec 27, 2024
1 parent fe43457 commit fe46e85
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,10 @@

<script>
(async () => {
await new Promise(requestAnimationFrame);
await test_driver.bless();
document.querySelector('select').showPicker();
await new Promise(requestAnimationFrame);
document.documentElement.classList.remove('reftest-wait');
})();
</script>
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,10 @@

<script>
(async () => {
await new Promise(requestAnimationFrame);
await test_driver.bless();
document.querySelector('select').showPicker();
await new Promise(requestAnimationFrame);
document.documentElement.classList.remove('reftest-wait');
})();
</script>
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@

<script>
(async () => {
await new Promise(requestAnimationFrame);
await test_driver.bless();
await new Promise(requestAnimationFrame);
try {
Expand Down

0 comments on commit fe46e85

Please sign in to comment.