Update some domain tests to follow latest 6265bis update. #31162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Oct 8, 2021
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3203692
branch
4 times, most recently
from
20ce927
to
23f848c
Compare
chromium-wpt-export-bot
changed the title
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3203692
branch
from
23f848c
to
3b83746
Compare
Also, add a few more tests inspired by bingler@'s GitHub comments. Previously, the cookie spec left an empty domain attribute as undefined behavior with SHOULD-level guidance. httpwg/http-extensions#1709 changes the spec to require handling of a cookie as a host cookie when its last domain attribute is empty. This matches the current behavior of Firefox and Safari. See httpwg/http-extensions#1332 for more discussion. Change-Id: Ibf4f243c929b11768ff406e940d6988a37434754 Bug: 1255273 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3203692 Reviewed-by: Steven Bingler <[email protected]> Commit-Queue: Mike Taylor <[email protected]> Cr-Commit-Position: refs/heads/main@{#931471}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3203692
branch
from
3b83746
to
26cd98a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, add a few more tests inspired by bingler@'s GitHub comments.
Previously, the cookie spec left an empty domain attribute as
undefined behavior with SHOULD-level guidance.
httpwg/http-extensions#1709 changes the
spec to require handling of a cookie as a host cookie when its
last domain attribute is empty. This matches the current behavior
of Firefox and Safari.
See httpwg/http-extensions#1332 for
more discussion.
Change-Id: Ibf4f243c929b11768ff406e940d6988a37434754
Bug: 1255273
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3203692
Reviewed-by: Steven Bingler <[email protected]>
Commit-Queue: Mike Taylor <[email protected]>
Cr-Commit-Position: refs/heads/main@{#931471}