Nested view transitions: adjust for border offset #48771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure the border width is only applied once when nesting. Since the parent group receives the border width and the child group computes its target transform based on its original position, by default the top/left border widths are considered twice. Adjust for this when computing the nested group transform. See w3c/csswg-drafts#10585 Bug: 347947051 Change-Id: I2f4c42cd861d41bbd8c99586946745ffcf1a4913 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5946105 Reviewed-by: Jeremy Roman <[email protected]> Reviewed-by: Mike West <[email protected]> Commit-Queue: Noam Rosenthal <[email protected]> Cr-Commit-Position: refs/heads/main@{#1372661}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5946105
branch
from
735b6c8 to
0592f08
Compare
wpt-pr-bot
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure the border width is only applied once when nesting.
Since the parent group receives the border width and the child group
computes its target transform based on its original position, by
default the top/left border widths are considered twice.
Adjust for this when computing the nested group transform.
See w3c/csswg-drafts#10585
Bug: 347947051
Change-Id: I2f4c42cd861d41bbd8c99586946745ffcf1a4913
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5946105
Reviewed-by: Jeremy Roman <[email protected]>
Reviewed-by: Mike West <[email protected]>
Commit-Queue: Noam Rosenthal <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1372661}