Add more tests for trusted-types-sink violation reports. #50276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This covers all Window-only sinks listed in w3c/trusted-types#494 (comment) This also adds small improvements to csp-violations.js: - Rely on connect-src / EventSource / self.add/removeEventListner, so that the file could be usable in Workers in the future. - Also force a connect-src violation before executing fn, so that we can flush previously reported violations. Although this is not necessary for existing tests, I noticed this can sometimes happen when I was trying to write tests.
fred-wang
force-pushed
the
trusted-types-reporting
branch
from
bfb43e4 to
a2c185e
Compare
lukewarlow
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This covers all Window-only sinks listed in
w3c/trusted-types#494 (comment)
This also relies on connect-src / EventSource / self.add/removeEventListner, so
that the file could be usable in Workers in the future.