Skip to content

merge_pr_48655

Compare
Choose a tag to compare
@github-actions github-actions released this 16 Oct 23:15

[text-decoration] Fix crashes for multiline ellipsis with ::first-line

The ellipsis should be styled according to the block[1]. It
was using the first-line style of the block, because it's the
common case, and it's the same style unless ::first-line is
applied.

This patch changes it to distinguish ellipsis on the first
line from other cases.

Wrong style can cause wrong rendering, but when
text-decoration is involved, it can confuse decoration box
calculation and result in crashes. This patch fixes both the
crashes and the correctness.

[1] https://www.w3.org/TR/css-overflow-3/#ellipsing-details

Fixed: 358957652
Change-Id: I26af0ae034876bdc0b0cc114670c52d24e2f36a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5936973
Commit-Queue: Kent Tamura [email protected]
Auto-Submit: Koji Ishii [email protected]
Reviewed-by: Kent Tamura [email protected]
Cr-Commit-Position: refs/heads/main@{#1369664}