Google Scoped Login #804
Merged
Google Scoped Login #804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: I also changed auth.py so that if one of these OAuth2 plugins is used, and the login expires, the user is redirected by AuthEnforcer to the plugin URL, and not to the form that asks to login with username/password. In fact, if a site is using one of these OAuth2 plugins, there is most likely no username/password for the user, and so showing the form is quite confusing. |
mdipierro
requested changes
Aug 5, 2023
| self.secrets_file = secrets_file | ||
| # Scopes for which we ask authorization | ||
| scopes = scopes or [] | ||
| self.scopes = ["openid", |
There was a problem hiding this comment.
It is not clear which members are supposed to be accessed publicly and which not, for the latter we should use an _ prefix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a new auth plugin, which implements google Oauth2 login with the ability to get additional scopes.
There are some differences wrt. other OAuth2 plugins:
- The plugin uses the database, and creates an auth_credentials table to
store the credentials for the scopes requested.
- The plugin relies on some google libraries (see on top), so these
need to be installed.
- The plugin takes in input a .json credentials file that can be
downloaded from Google Cloud when creating the OAuth2 credentials.
This has been tested.