Auth TOTP fix #925
Merged
Auth TOTP fix #925
+80
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m validation of the second factor authentication token
|
...on a second thought, Massimo - don't merge this PR into master yet. I think it would be actually useful and user friendly to hide some currently exposed plumbing (such as the session variables, form variable, etc). I just had an idea how to make this better 😜 So let me fix it first, and then we can discuss if needed. |
|
Ok - I cleaned-up the code and updated the documentation. I think it is ready now for a review 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes to add
two_factor_validatecallback to Auth in order to be able to handle custom two-factor code validation, and in particular handling the case of Time-Based One-Time-Passwords (TOTP).Two commits are proposed - one to modify the code, and the other to update the documentation.