[WIP] UUID as primary key #443
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-burke-codes
force-pushed
the
return-uuid-on-insert
branch
from
40f0825
to
a73a097
Compare
Current coverage is 68.65% (diff: 60.00%)@@ master #443 diff @@
==========================================
Files 69 69
Lines 9163 9167 +4
Methods 0 0
Messages 0 0
Branches 1987 1983 -4
==========================================
Hits 6294 6294
- Misses 2347 2351 +4
Partials 522 522
|
|
@gi0baro I am fine with this. If you are too, I would merge it. |
|
@mdipierro I'm not really happy with the implementation. IMHO if we really want to support this we should plan a complete implementation. |
|
@mdipierro also, this should still be considered a Work in progress, see the title. |
|
I agree. In the case of Mongodb, my original approach was to map UUIDs in long integers and vice versa. |
|
+1 for string id support. My application requires a string id field and it looks like currently there's no way I can make that work. |
mdipierro
force-pushed
the
master
branch
2 times, most recently
from
3b526f9
to
2a77f13
Compare
|
I am going to decline this. It is a good idea but requires a lot more changes than this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolution to issue #442
This pull request will enable Postgresql users to use a UUID as a primary key. Currently when trying to do an insert the code expects an integer to be returned resulting in a ValueError exception.