feat: put files (client) #12
Conversation
vasco-santos
force-pushed
the
feat/add-car
branch
from
46f7b98 to
3e5bb9d
Compare
| const data2 = 'Hello web3.storage!!' | ||
|
|
||
| return [ | ||
| Web3File.fromBytes( |
There was a problem hiding this comment.
Should we Web3File.fromText() web3-storage/web3-file#5
There was a problem hiding this comment.
yey, just need to get it merged+shipped web3-storage/web3-file#4 to update here
packages/client/test/put.spec.js
Outdated
| }) | ||
|
|
||
| it('erros with a File that will not be parsed by the Cluster', async function () { | ||
| this.timeout(35e10) // This needs to happen because of retry... |
There was a problem hiding this comment.
Perhaps add timeout and retry as configurable options to put?
There was a problem hiding this comment.
Added to options as suggested, with default value from constant
Co-authored-by: Oli Evans <[email protected]>
packages/client/src/lib.js
Outdated
| } | ||
|
|
||
| // Destroy Blockstore | ||
| await blockstore.destroy() |
There was a problem hiding this comment.
Needs to be in a finally so always gets cleaned even if error.
There was a problem hiding this comment.
Good catch! I found a bug in FsBlockstore that needs to get it to not break CI here: storacha/ipfs-car#49
| */ | ||
| store(blob) { | ||
| return Web3Storage.store(this, blob) | ||
| put(files, options) { |
There was a problem hiding this comment.
How are we going to expose the CID to the user before upload?
There was a problem hiding this comment.
I am thinking on an option:
onCarCreated(cid: CID), but I am leaving this to follow up PR to discuss
Co-authored-by: Alan Shaw <[email protected]>
| Web3File.fromText( | ||
| data2, | ||
| 'data2.zip', | ||
| { path: '/dir/otherdir/data2.zip' } |
There was a problem hiding this comment.
Can we use .txt so that they render properly if people ever open them on the gateway?
There was a problem hiding this comment.
Done! Bear in mind that examples are still a WIP, I want to follow up on them with:
- docs
- integrate get
- add tests 🤖
| "serve": "vite preview" | ||
| }, | ||
| "devDependencies": { | ||
| "vite": "^2.3.7" |
There was a problem hiding this comment.
yes, the alternative is using skypack which is problematic by storacha/ipfs-car#27
I need to book some time next week to try to figure out an work around for that
fix Fixing the root redirect & Updating readme
This PR adds:
Needs: