Skip to content

Commit

Permalink
Merge branch 'development' into task-bre-params
Browse files Browse the repository at this point in the history
  • Loading branch information
tmilar committed Mar 26, 2020
2 parents e090a43 + 0152d64 commit 875e581
Show file tree
Hide file tree
Showing 159 changed files with 7,531 additions and 3,229 deletions.
1 change: 1 addition & 0 deletions .gitattributes
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
*.sol linguist-language=Solidity
# prevent github actions to checkout files with crlf line endings
* -text
9 changes: 8 additions & 1 deletion .github/workflows/CI.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,13 @@
name: CI

on: [pull_request, push]
on:
push:
branches:
- master
- development
pull_request:
branches:
- "*"

jobs:
lint:
Expand Down
8 changes: 2 additions & 6 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ package-lock.json

.DS_Store

# Below is Github's node gitignore template, except for dotenv's entries as it's used by mocha to pass flags to ts-node,
# and ignoring the node_modules part, as it'd ignore every node_modules, and we have some for testing
# Below is Github's node gitignore template,
# ignoring the node_modules part, as it'd ignore every node_modules, and we have some for testing

# Logs
logs
Expand Down Expand Up @@ -71,10 +71,6 @@ typings/
# Yarn Integrity file
.yarn-integrity

# dotenv environment variables file
#.env
#.env.test

# parcel-bundler cache (https://parceljs.org/)
.cache

Expand Down
13 changes: 12 additions & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,9 @@ docker pull ethereum/vyper:0.1.0b10
```

### Entire project
You can run all the tests at once by running `npm test` from the root folder. Requires `ethereum/vyper` docker instance installed for package [buidler-vyper](./packages/buidler-vyper), see previous section for details.
You can run all the tests at once by running `npm test` from the root folder.

For the case of package [buidler-vyper](./packages/buidler-vyper), an `ethereum/vyper` docker instance installed is required (see previous section for details). _Exception_ of this requirement is if running on a Windows local machine, in this case we skip it by default since Win 10 Pro version would be also required.

## Code formatting

Expand All @@ -46,6 +48,15 @@ Prettier and forbids some dangerous patterns.
The linter is always run in the CI, so make sure it passes before pushing code. You can use `npm run lint` and
`npm run lint:fix` inside the packages' folders.

## Branching

We work on the branch [`development`](https://github.com/nomiclabs/buidler/tree/development)
and keep `master` in sync with the latest release.

Please, branch from `development` when implementing a new feature or fixing a
bug, and use it as the base branch in every pull request.


## Dependencies

We keep our dependencies versions in sync between the different projects.
Expand Down
Loading

0 comments on commit 875e581

Please sign in to comment.