Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin implementation #1

Merged
merged 13 commits into from
May 15, 2024
Merged

Plugin implementation #1

merged 13 commits into from
May 15, 2024

Conversation

avkos
Copy link
Contributor

@avkos avkos commented Oct 19, 2023

No description provided.

package.json Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
@avkos avkos marked this pull request as ready for review April 18, 2024 15:08
package.json Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
@avkos
Copy link
Contributor Author

avkos commented Apr 24, 2024

Build will not work until we not merge and make new realse with these changes

After this I need to change version of web3

@avkos avkos requested a review from jdevcs April 24, 2024 23:04
src/plugin.ts Show resolved Hide resolved
Copy link
Contributor

@jdevcs jdevcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, except after merging PR in main web3.js tests should be passing for merging this PR. Thanks @avkos

src/plugin.ts Outdated Show resolved Hide resolved
@avkos avkos requested a review from jdevcs April 25, 2024 20:08
@avkos avkos merged commit ad14ff6 into master May 15, 2024
2 of 3 checks passed
@avkos avkos deleted the plugin branch May 15, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants