Skip to content

Commit

Permalink
add changelog
Browse files Browse the repository at this point in the history
  • Loading branch information
avkos committed Oct 26, 2023
1 parent 51cdaf2 commit 6c85a4e
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 6 deletions.
7 changes: 6 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2225,4 +2225,9 @@ If there are any bugs, improvements, optimizations or any new feature proposal f

- Dependencies updated

## [Unreleased]
## [Unreleased]
### Added

#### web3-types

- `gasPrice` was added to `Transaction1559UnsignedAPI` type. (#6539)
7 changes: 3 additions & 4 deletions packages/web3-eth/src/rpc_method_wrappers.ts
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@ import {
TransactionForAccessList,
AccessListResult,
Eip712TypedData,
TransactionWithSenderAPI,
} from 'web3-types';
import { Web3Context, Web3PromiEvent } from 'web3-core';
import { format, hexToBytes, bytesToUint8Array, numberToHex } from 'web3-utils';
Expand Down Expand Up @@ -740,7 +739,7 @@ export async function signTransaction<ReturnFormat extends DataFormat>(
) {
const response = await ethRpcMethods.signTransaction(
web3Context.requestManager,
formatTransaction(transaction as TransactionWithSenderAPI, ETH_DATA_FORMAT),
formatTransaction(transaction, ETH_DATA_FORMAT),
);
// Some clients only return the encoded signed transaction (e.g. Ganache)
// while clients such as Geth return the desired SignedTransactionInfoAPI object
Expand Down Expand Up @@ -803,7 +802,7 @@ export async function estimateGas<ReturnFormat extends DataFormat>(

const response = await ethRpcMethods.estimateGas(
web3Context.requestManager,
transactionFormatted as TransactionWithSenderAPI,
transactionFormatted,
blockNumberFormatted,
);

Expand Down Expand Up @@ -951,7 +950,7 @@ export async function createAccessList<ReturnFormat extends DataFormat>(

const response = (await ethRpcMethods.createAccessList(
web3Context.requestManager,
formatTransaction(transaction as TransactionWithSenderAPI, ETH_DATA_FORMAT),
formatTransaction(transaction, ETH_DATA_FORMAT),
blockNumberFormatted,
)) as unknown as AccessListResult;

Expand Down
5 changes: 4 additions & 1 deletion packages/web3-types/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -170,4 +170,7 @@ Documentation:

- Interface `EventLog` was added. (#6410)

## [Unreleased]
## [Unreleased]

### Added
- `gasPrice` was added to `Transaction1559UnsignedAPI` type. (#6539)

0 comments on commit 6c85a4e

Please sign in to comment.