chore: reexport signature types, add changelogs

web3 · Nov 11, 2024 · b886b1c · b886b1c
1 parent 6919860
commit b886b1c
Show file tree

Hide file tree

Showing 7 changed files with 31 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2803,3 +2803,9 @@ If there are any bugs, improvements, optimizations or any new feature proposal f
 -   Fix Contract methods input param type any[] (#7340)
 
 ## [Unreleased]
+
+### Fixed
+
+#### web3
+
+-   Export Web3Account, Wallet and signature related types. (#7374)
diff --git a/packages/web3-eth-accounts/CHANGELOG.md b/packages/web3-eth-accounts/CHANGELOG.md
@@ -190,3 +190,7 @@ Documentation:
 -   `hashMessage` now has a new optional param `skipPrefix` with a default value of `false`. A new function `signRaw` was added to sign a message without prefix. (#7346)
 
 ## [Unreleased]
+
+### Removed
+
+-   Move signature related types to web3-types. Re-export them for backwards compatibility. (#7374)
diff --git a/packages/web3-eth-accounts/src/types.ts b/packages/web3-eth-accounts/src/types.ts
@@ -15,9 +15,17 @@ You should have received a copy of the GNU Lesser General Public License
 along with web3.js.  If not, see <http://www.gnu.org/licenses/>.
 */
 
-import { Web3BaseWalletAccount, HexString } from 'web3-types';
+import {
+	HexString,
+	SignatureObject,
+	SignResult,
+	SignTransactionResult,
+	Web3BaseWalletAccount,
+} from 'web3-types';
 import { AccessListEIP2930Transaction, FeeMarketEIP1559Transaction, Transaction } from './tx';
 
+export { SignatureObject, SignResult, SignTransactionResult };
+
 export interface Web3Account extends Web3BaseWalletAccount {
 	address: HexString;
 	privateKey: HexString;

diff --git a/packages/web3-types/CHANGELOG.md b/packages/web3-types/CHANGELOG.md
@@ -221,3 +221,7 @@ Documentation:
 -   `FilterParams` type added (#7353)
 
 ## [Unreleased]
+
+#### Added
+
+-   Add signature related types. (#7374)
diff --git a/packages/web3/CHANGELOG.md b/packages/web3/CHANGELOG.md
@@ -561,3 +561,9 @@ Documentation:
 -   Fix Contract methods input param type any[] (#7340)
 
 ## [Unreleased]
+
+### Fixed
+
+#### web3
+
+-   Export Web3Account, Wallet and signature related types. (#7374)
diff --git a/packages/web3/src/index.ts b/packages/web3/src/index.ts
@@ -364,4 +364,3 @@ export * as validator from 'web3-validator';
  */
 export * from 'web3-errors';
 export * from 'web3-types';
-export type { Web3Account, Wallet } from 'web3-eth-accounts';
diff --git a/packages/web3/src/types.ts b/packages/web3/src/types.ts
@@ -42,6 +42,8 @@ import { Net } from 'web3-net';
 import { Iban } from 'web3-eth-iban';
 import { Personal } from 'web3-eth-personal';
 
+export type { Web3Account, Wallet } from 'web3-eth-accounts';
+
 /**
  * The Ethereum interface for main web3 object. It provides extra methods in addition to `web3-eth` interface.
  *