format and update changelog

web3 · Oct 24, 2023 · c4896e7 · c4896e7
1 parent 2a30055
commit c4896e7
Show file tree

Hide file tree

Showing 5 changed files with 18 additions and 13 deletions.
diff --git a/packages/web3-core/CHANGELOG.md b/packages/web3-core/CHANGELOG.md
@@ -192,3 +192,7 @@ Documentation:
 -   Fix the issue: "Uncaught TypeError: Class extends value undefined is not a constructor or null #6371". (#6398)
 
 ## [Unreleased]
+
+### Added
+
+-   Added `isMetaMaskProvider` function to check if provider is metamask (#6534)
diff --git a/packages/web3-core/src/utils.ts b/packages/web3-core/src/utils.ts
@@ -23,7 +23,7 @@ import {
 	SupportedProviders,
 	Web3APISpec,
 	Web3BaseProvider,
-	MetamaskProvider,
+	MetaMaskProvider,
 } from 'web3-types';
 
 export const isWeb3Provider = <API extends Web3APISpec>(
@@ -32,7 +32,7 @@ export const isWeb3Provider = <API extends Web3APISpec>(
 
 export const isMetaMaskProvider = <API extends Web3APISpec>(
 	provider: SupportedProviders<API>,
-): provider is MetamaskProvider<API> =>{
+): provider is MetaMaskProvider<API> =>{
 return typeof provider !== 'string' &&
 'request' in provider &&
 provider.request.constructor.name === 'AsyncFunction' && 'isMetaMask' in provider && provider.isMetaMask;

diff --git a/packages/web3-eth-contract/CHANGELOG.md b/packages/web3-eth-contract/CHANGELOG.md
@@ -314,4 +314,8 @@ Documentation:
 
 -   The `events` property was added to the `receipt` object (#6410)
 
-## [Unreleased]
+## [Unreleased]
+
+### Fixed
+
+-	Will populate `data` for transactions in contract for metamask provider instead of `input` (#6534)
diff --git a/packages/web3-types/CHANGELOG.md b/packages/web3-types/CHANGELOG.md
@@ -170,4 +170,8 @@ Documentation:
 
 -   Interface `EventLog` was added. (#6410)
 
-## [Unreleased]
+## [Unreleased]
+
+### Added
+
+-   Interface `MetaMaskProvider` added and is part of `SupportedProviders` (#6534)
diff --git a/packages/web3-types/src/web3_base_provider.ts b/packages/web3-types/src/web3_base_provider.ts
@@ -134,7 +134,7 @@ export interface EIP1193Provider<API extends Web3APISpec> extends SimpleProvider
 	removeListener(event: 'accountsChanged', listener: (accounts: ProviderAccounts) => void): void;
 }
 
-export interface MetamaskProvider<API extends Web3APISpec> extends SimpleProvider<API> {
+export interface MetaMaskProvider<API extends Web3APISpec> extends SimpleProvider<API> {
 	on(event: 'connect', listener: (info: ProviderInfo) => void): void;
 	on(event: 'disconnect', listener: (error: ProviderRpcError) => void): void;
 	on(event: 'message', listener: (message: ProviderMessage) => void): void;
@@ -175,13 +175,6 @@ export abstract class Web3BaseProvider<API extends Web3APISpec = EthExecutionAPI
 		);
 	}
 
-	public static isMetamaskProvider(provider: unknown) {
-		return (
-			provider  && 
-			Boolean(provider && (provider as { [symbol]: boolean })[symbol])
-		);
-	}
-
 	// To match an object "instanceof" does not work if
 	// matcher class and object is using different package versions
 	// to overcome this bottleneck used this approach.
@@ -350,7 +343,7 @@ export type SupportedProviders<API extends Web3APISpec = Web3EthExecutionAPI> =
 	| LegacySendProvider
 	| LegacySendAsyncProvider
 	| SimpleProvider<API>
-	| MetamaskProvider<API>;
+	| MetaMaskProvider<API>;
 
 export type Web3BaseProviderConstructor = new <API extends Web3APISpec>(
 	url: string,