Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release - v1.0.0-beta.51 #2598

Merged
merged 10 commits into from
Mar 28, 2019
Merged

Release - v1.0.0-beta.51 #2598

merged 10 commits into from
Mar 28, 2019

Conversation

nivida
Copy link
Contributor

@nivida nivida commented Mar 28, 2019

Description

Fixed issues:

#2587 #2560 #2542 #2595 #2591 #2553 #2583 #1021 #1517 #1074 #1169 #2033 #1793 #1126 #1134 #2578 #2569 #2563 #2571 #2570 #2565 #2558 #2559 #1802 #2551 #2554 #2555 #2539 #2532 #2350

Compare view beta.50 - beta.51

Type of change

  • Release

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no warnings.
  • I have updated or added types for all modules I've changed
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run test in the root folder with success and extended the tests if necessary.
  • I ran npm run build in the root folder and tested it in the browser and with node.
  • I ran npm run dtslint in the root folder and tested that all my types are correct
  • I have tested my code on an ethereum test network.

…sed manually otherwise the web3.version property will return the wrong version
@nivida nivida added In Progress Currently being worked on Release labels Mar 28, 2019
@nivida nivida removed the In Progress Currently being worked on label Mar 28, 2019
@coveralls
Copy link

coveralls commented Mar 28, 2019

Coverage Status

Coverage decreased (-0.04%) to 95.692% when pulling 67468b3 on release/1.0.0-beta.51 into 894c55c on 1.0.

@nivida nivida merged commit 14a65eb into 1.0 Mar 28, 2019
@krychla1
Copy link

v1.0.0-beta.51 fixed the #2518->#2542, thank you, however new problem appeared.

sendSignedTransaction now throws timeout error (tx wasn't mined) despite it has been mined long before the timeout.
The exception object also contains valid receipt, confirmations, confirmationChecks, etc.

@nivida nivida deleted the release/1.0.0-beta.51 branch March 28, 2019 18:18
@mesirendon
Copy link

I just updated to beta 51 and it seems to have resolved the previous issue with the status (can't confirm though), but now I got another issue. It gets stuck getting the transaction receipt and getting the block by its number. I've attached a gif of my test.

It gets properly initialized, then trying to execute the first transaction is where it gets stuck.

web3

I can provide more feedback of my code if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants