Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6366 Add instructions to the doc for the plugin naming #6446

Merged
merged 4 commits into from
Sep 22, 2023

Conversation

avkos
Copy link
Contributor

@avkos avkos commented Sep 19, 2023

Description

Please include a summary of the changes and be sure to follow our Contribution Guidelines.

Fixes #6366

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run lint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:coverage and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have linked Issue(s) with this PR in "Linked Issues" menu.

@avkos avkos changed the title 6366 add instructions to the doc about the plugin naming 6366 Add instructions to the doc for the plugin naming Sep 19, 2023
@github-actions
Copy link

github-actions bot commented Sep 19, 2023

Bundle Stats

Hey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Asset Old size New size Diff Diff %
Total 655 KB 657 KB 2.04 KB 0.31%
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset Old size New size Diff Diff %
web3.min.js 638 KB 640 KB 2.04 KB 0.32%
../lib/commonjs/index.d.ts 8.56 KB 8.56 KB 0 0.00%
../lib/commonjs/accounts.d.ts 3.67 KB 3.67 KB 0 0.00%
../lib/commonjs/types.d.ts 2.45 KB 2.45 KB 0 0.00%
../lib/commonjs/web3.d.ts 1.14 KB 1.14 KB 0 0.00%
../lib/commonjs/abi.d.ts 1000 bytes 1000 bytes 0 0.00%
../lib/commonjs/eth.exports.d.ts 280 bytes 280 bytes 0 0.00%
../lib/commonjs/providers.exports.d.ts 148 bytes 148 bytes 0 0.00%
../lib/commonjs/version.d.ts 60 bytes 60 bytes 0 0.00%

@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #6446 (a4f2d8d) into 4.x (2b445bf) will increase coverage by 0.72%.
Report is 2 commits behind head on 4.x.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##              4.x    #6446      +/-   ##
==========================================
+ Coverage   89.15%   89.88%   +0.72%     
==========================================
  Files         199      201       +2     
  Lines        7756     7779      +23     
  Branches     2147     2129      -18     
==========================================
+ Hits         6915     6992      +77     
+ Misses        841      787      -54     
Flag Coverage Δ
UnitTests 89.88% <ø> (+0.72%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
web3 ∅ <ø> (∅)
web3-core ∅ <ø> (∅)
web3-errors ∅ <ø> (∅)
web3-eth ∅ <ø> (∅)
web3-eth-abi ∅ <ø> (∅)
web3-eth-accounts ∅ <ø> (∅)
web3-eth-contract ∅ <ø> (∅)
web3-eth-ens ∅ <ø> (∅)
web3-eth-iban ∅ <ø> (∅)
web3-eth-personal ∅ <ø> (∅)
web3-net ∅ <ø> (∅)
web3-providers-http ∅ <ø> (∅)
web3-providers-ipc ∅ <ø> (∅)
web3-providers-ws ∅ <ø> (∅)
web3-rpc-methods ∅ <ø> (∅)
web3-utils ∅ <ø> (∅)
web3-validator ∅ <ø> (∅)

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Sep 19, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: a4f2d8d
Status: ✅  Deploy successful!
Preview URL: https://6d5bacfc.web3-js-docs.pages.dev
Branch Preview URL: https://ok-6366-add-instructions-to.web3-js-docs.pages.dev

View logs

@avkos
Copy link
Contributor Author

avkos commented Sep 19, 2023

image

@avkos avkos merged commit d036166 into 4.x Sep 22, 2023
@avkos avkos deleted the ok/6366-Add-instructions-to-the-doc-for-the-plugin-naming branch September 22, 2023 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add instructions to the doc for the plugin naming
4 participants