-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Conversation
#6447 will also be fixed, |
* @param func - The function to call. | ||
* @param interval - The interval in milliseconds. | ||
*/ | ||
export async function pollTillDefined<T>( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
keeping pollTillDefined
so we dnt break API as its exported function from utils.
Bundle StatsHey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 4.x #6464 +/- ##
==========================================
+ Coverage 89.39% 89.59% +0.19%
==========================================
Files 212 212
Lines 8140 8141 +1
Branches 2213 2213
==========================================
+ Hits 7277 7294 +17
+ Misses 863 847 -16
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Deploying with
|
Latest commit: |
7369e7c
|
Status: | ✅ Deploy successful! |
Preview URL: | https://981b1d5b.web3-js-docs.pages.dev |
Branch Preview URL: | https://junaid-4xtxwaitfix.web3-js-docs.pages.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coverage decreased. Will be great to fix it
712ef21
to
0aade03
Compare
Description
#6328
Type of change
Checklist:
npm run lint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:coverage
and my test cases cover all the lines and branches of the added code.npm run build
and testeddist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.