Skip to content
This repository has been archived by the owner on Mar 5, 2025. It is now read-only.

waitForTransactionReceipt fix #6464

Merged
merged 12 commits into from
Oct 5, 2023
Merged

waitForTransactionReceipt fix #6464

merged 12 commits into from
Oct 5, 2023

Conversation

jdevcs
Copy link
Contributor

@jdevcs jdevcs commented Sep 27, 2023

Description

#6328

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run lint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:coverage and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have linked Issue(s) with this PR in "Linked Issues" menu.

@jdevcs jdevcs added the 4.x 4.0 related label Sep 27, 2023
@jdevcs
Copy link
Contributor Author

jdevcs commented Sep 27, 2023

#6447 will also be fixed,
For terminating receipt looking logic in less time, just set web3.transactionPollingTimeout to some lower value if you want lower thn predefined.

* @param func - The function to call.
* @param interval - The interval in milliseconds.
*/
export async function pollTillDefined<T>(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keeping pollTillDefined so we dnt break API as its exported function from utils.

@github-actions
Copy link

github-actions bot commented Sep 27, 2023

Bundle Stats

Hey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Asset Old size New size Diff Diff %
Total 583 KB 583 KB 97 bytes 0.02%
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset Old size New size Diff Diff %
web3.min.js 566 KB 566 KB 97 bytes 0.02%
../lib/commonjs/index.d.ts 8.56 KB 8.56 KB 0 0.00%
../lib/commonjs/accounts.d.ts 3.67 KB 3.67 KB 0 0.00%
../lib/commonjs/types.d.ts 2.45 KB 2.45 KB 0 0.00%
../lib/commonjs/web3.d.ts 1.14 KB 1.14 KB 0 0.00%
../lib/commonjs/abi.d.ts 1000 bytes 1000 bytes 0 0.00%
../lib/commonjs/eth.exports.d.ts 280 bytes 280 bytes 0 0.00%
../lib/commonjs/providers.exports.d.ts 148 bytes 148 bytes 0 0.00%
../lib/commonjs/version.d.ts 60 bytes 60 bytes 0 0.00%

@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Merging #6464 (7369e7c) into 4.x (80986bb) will increase coverage by 0.19%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##              4.x    #6464      +/-   ##
==========================================
+ Coverage   89.39%   89.59%   +0.19%     
==========================================
  Files         212      212              
  Lines        8140     8141       +1     
  Branches     2213     2213              
==========================================
+ Hits         7277     7294      +17     
+ Misses        863      847      -16     
Flag Coverage Δ
UnitTests 89.59% <100.00%> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
web3 ∅ <ø> (∅)
web3-core ∅ <ø> (∅)
web3-errors ∅ <ø> (∅)
web3-eth ∅ <ø> (∅)
web3-eth-abi ∅ <ø> (∅)
web3-eth-accounts ∅ <ø> (∅)
web3-eth-contract ∅ <ø> (∅)
web3-eth-ens ∅ <ø> (∅)
web3-eth-iban ∅ <ø> (∅)
web3-eth-personal ∅ <ø> (∅)
web3-net ∅ <ø> (∅)
web3-providers-http ∅ <ø> (∅)
web3-providers-ipc ∅ <ø> (∅)
web3-providers-ws ∅ <ø> (∅)
web3-rpc-methods ∅ <ø> (∅)
web3-utils ∅ <ø> (∅)
web3-validator ∅ <ø> (∅)

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Sep 27, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 7369e7c
Status: ✅  Deploy successful!
Preview URL: https://981b1d5b.web3-js-docs.pages.dev
Branch Preview URL: https://junaid-4xtxwaitfix.web3-js-docs.pages.dev

View logs

Copy link
Contributor

@avkos avkos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coverage decreased. Will be great to fix it

@jdevcs jdevcs merged commit 6d99cd0 into 4.x Oct 5, 2023
@jdevcs jdevcs deleted the junaid/4xtxwaitfix branch October 5, 2023 14:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
4.x 4.0 related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants