Add functionality to extend tx types #6493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er-for-new-transaction-types
Bundle StatsHey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 4.x #6493 +/- ##
=======================================
Coverage 89.66% 89.67%
=======================================
Files 214 214
Lines 8206 8222 +16
Branches 2220 2223 +3
=======================================
+ Hits 7358 7373 +15
- Misses 848 849 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Deploying with
|
| Latest commit: |
6eb3cd9
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e0fe95fd.web3-js-docs.pages.dev |
| Branch Preview URL: | https://ok-6459-4-x--enable-plugins.web3-js-docs.pages.dev |
avkos
requested review from
jdevcs,
luu-alex and
Muhammad-Altabba
as code owners
avkos
commented
Oct 12, 2023
| } from '../common/index.js'; | ||
| import { toUint8Array, uint8ArrayToBigInt, unpadUint8Array } from '../common/utils.js'; | ||
| import { Common } from '../common/common.js'; | ||
| import { Hardfork, Chain } from '../common/enums.js'; |
| @@ -89,7 +89,7 @@ export async function getTransactionGasPricing<ReturnFormat extends DataFormat>( | |||
| throw new UnsupportedTransactionTypeError(transactionType); | |||
|
|
|||
| // https://github.com/ethereum/EIPs/blob/master/EIPS/eip-2718.md#transactions | |||
| if (transactionType < '0x0' || transactionType > '0x7f') | |||
| if (Number(transactionType) < 0 || Number(transactionType) > 127) | |||
There was a problem hiding this comment.
fix incorrect string comparing to numbers
…er-for-new-transaction-types
jdevcs
reviewed
Oct 13, 2023
jdevcs
reviewed
Oct 13, 2023
…er-for-new-transaction-types
…er-for-new-transaction-types
Muhammad-Altabba
approved these changes
Oct 16, 2023
| maxFeePerGas: BigInt(5000000), | ||
| }; | ||
| const sub = web3.eth.sendTransaction({ ...tx }, undefined, { | ||
| checkRevertBeforeSending: false, |
There was a problem hiding this comment.
Why do we need checkRevertBeforeSending: false, please?
I think the user should not be forced to pass it. Except if there is no other way. And if so, this has to be be documented.
avkos
deleted the
ok/6459-4.x]-Enable-plugins-to-register-builder-for-new-transaction-types
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the changes and be sure to follow our Contribution Guidelines.
Fixes #6459
Type of change
Checklist:
npm run lintwith success and extended the tests and types if necessary.npm run test:unitwith success.npm run test:coverageand my test cases cover all the lines and branches of the added code.npm run buildand testeddist/web3.min.jsin a browser.CHANGELOG.mdfile in the root folder.