-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ankr provider #7260
Ankr provider #7260
Conversation
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark
Benchmark suite | Current: de19a1a | Previous: b3cb1b7 | Ratio |
---|---|---|---|
processingTx |
22231 ops/sec (±7.51% ) |
21696 ops/sec (±8.85% ) |
0.98 |
processingContractDeploy |
38595 ops/sec (±5.39% ) |
40328 ops/sec (±6.93% ) |
1.04 |
processingContractMethodSend |
14873 ops/sec (±8.76% ) |
17416 ops/sec (±6.78% ) |
1.17 |
processingContractMethodCall |
27671 ops/sec (±6.83% ) |
28028 ops/sec (±7.80% ) |
1.01 |
abiEncode |
42136 ops/sec (±7.57% ) |
46457 ops/sec (±6.59% ) |
1.10 |
abiDecode |
29800 ops/sec (±8.23% ) |
31537 ops/sec (±7.34% ) |
1.06 |
sign |
1533 ops/sec (±0.85% ) |
1584 ops/sec (±0.53% ) |
1.03 |
verify |
353 ops/sec (±3.12% ) |
364 ops/sec (±2.47% ) |
1.03 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.x #7260 +/- ##
=======================================
Coverage 94.44% 94.44%
=======================================
Files 216 216
Lines 8454 8454
Branches 2335 2335
=======================================
Hits 7984 7984
Misses 470 470
Flags with carried forward coverage won't be shown. Click here to find out more. |
@@ -46,8 +46,20 @@ describe('Web3 RPC Provider Integration tests', () => { | |||
web3.provider?.disconnect(); | |||
} | |||
}); | |||
|
|||
if (transport !== Transport.WebSocket) { | |||
it.skip(`AnkrProvider should work with ${transport} transport and ${network} network`, async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
skipped as key not added yet
This PR has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. If you believe this was a mistake, please comment. |
Description
#6974
#7263
Type of change
Checklist:
npm run lint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:coverage
and my test cases cover all the lines and branches of the added code.npm run build
and testeddist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.