Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ankr provider #7260

Closed
wants to merge 4 commits into from
Closed

Ankr provider #7260

wants to merge 4 commits into from

Conversation

jdevcs
Copy link
Contributor

@jdevcs jdevcs commented Sep 17, 2024

Description

#6974
#7263

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run lint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:coverage and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have linked Issue(s) with this PR in "Linked Issues" menu.

Copy link

Bundle Stats

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
10 639.62 kB → 640.54 kB (+936 B) +0.14%
Changeset
File Δ Size
../web3-rpc-providers/lib/commonjs/web3_provider_ankr.js 🆕 +2.33 kB 0 B → 2.33 kB
../web3-rpc-providers/lib/commonjs/index.js 📈 +59 B (+3.18%) 1.81 kB → 1.87 kB
../web3-rpc-providers/lib/commonjs/web3_provider_quicknode.js 📉 -1 B (-0.02%) 5.41 kB → 5.41 kB
../web3-rpc-providers/lib/commonjs/types.js 📉 -2 B (-0.11%) 1.75 kB → 1.75 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
web3.min.js 620.22 kB → 621.13 kB (+936 B) +0.15%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
../lib/commonjs/index.d.ts 8.69 kB 0%
../lib/commonjs/accounts.d.ts 3.89 kB 0%
../lib/commonjs/types.d.ts 2.67 kB 0%
../lib/commonjs/web3.d.ts 1.38 kB 0%
../lib/commonjs/web3_eip6963.d.ts 1.28 kB 0%
../lib/commonjs/abi.d.ts 999 B 0%
../lib/commonjs/eth.exports.d.ts 280 B 0%
../lib/commonjs/providers.exports.d.ts 183 B 0%
../lib/commonjs/version.d.ts 60 B 0%

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: de19a1a Previous: b3cb1b7 Ratio
processingTx 22231 ops/sec (±7.51%) 21696 ops/sec (±8.85%) 0.98
processingContractDeploy 38595 ops/sec (±5.39%) 40328 ops/sec (±6.93%) 1.04
processingContractMethodSend 14873 ops/sec (±8.76%) 17416 ops/sec (±6.78%) 1.17
processingContractMethodCall 27671 ops/sec (±6.83%) 28028 ops/sec (±7.80%) 1.01
abiEncode 42136 ops/sec (±7.57%) 46457 ops/sec (±6.59%) 1.10
abiDecode 29800 ops/sec (±8.23%) 31537 ops/sec (±7.34%) 1.06
sign 1533 ops/sec (±0.85%) 1584 ops/sec (±0.53%) 1.03
verify 353 ops/sec (±3.12%) 364 ops/sec (±2.47%) 1.03

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.44%. Comparing base (b3cb1b7) to head (de19a1a).
Report is 60 commits behind head on 4.x.

Additional details and impacted files
@@           Coverage Diff           @@
##              4.x    #7260   +/-   ##
=======================================
  Coverage   94.44%   94.44%           
=======================================
  Files         216      216           
  Lines        8454     8454           
  Branches     2335     2335           
=======================================
  Hits         7984     7984           
  Misses        470      470           
Flag Coverage Δ
UnitTests 94.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@@ -46,8 +46,20 @@ describe('Web3 RPC Provider Integration tests', () => {
web3.provider?.disconnect();
}
});

if (transport !== Transport.WebSocket) {
it.skip(`AnkrProvider should work with ${transport} transport and ${network} network`, async () => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

skipped as key not added yet

@jdevcs jdevcs mentioned this pull request Sep 17, 2024
4 tasks
@jdevcs jdevcs marked this pull request as ready for review September 30, 2024 11:09
@mconnelly8 mconnelly8 mentioned this pull request Oct 1, 2024
3 tasks
Copy link

This PR has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. If you believe this was a mistake, please comment.

@github-actions github-actions bot added the Stale Has not received enough activity label Nov 30, 2024
@github-actions github-actions bot closed this Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stale Has not received enough activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants