-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Documentation for React Native #7419
Conversation
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark
Benchmark suite | Current: ebfdcd1 | Previous: 594f83a | Ratio |
---|---|---|---|
processingTx |
22641 ops/sec (±6.43% ) |
23821 ops/sec (±6.52% ) |
1.05 |
processingContractDeploy |
37494 ops/sec (±7.92% ) |
38684 ops/sec (±8.01% ) |
1.03 |
processingContractMethodSend |
14637 ops/sec (±10.01% ) |
15406 ops/sec (±8.61% ) |
1.05 |
processingContractMethodCall |
26595 ops/sec (±6.93% ) |
27007 ops/sec (±7.65% ) |
1.02 |
abiEncode |
41664 ops/sec (±7.73% ) |
43472 ops/sec (±7.00% ) |
1.04 |
abiDecode |
28200 ops/sec (±8.34% ) |
30982 ops/sec (±6.75% ) |
1.10 |
sign |
1487 ops/sec (±0.93% ) |
1524 ops/sec (±3.52% ) |
1.02 |
verify |
357 ops/sec (±0.89% ) |
365 ops/sec (±0.65% ) |
1.02 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.x #7419 +/- ##
=======================================
Coverage 94.54% 94.54%
=======================================
Files 218 218
Lines 8637 8637
Branches 2364 2364
=======================================
Hits 8166 8166
Misses 471 471
Flags with carried forward coverage won't be shown. Click here to find out more. |
@@ -44,6 +44,24 @@ Additional Info: | |||
|
|||
[Facebook/React-native Issue #28492](https://github.com/facebook/react-native/issues/28492#issuecomment-824698934) | |||
|
|||
### TypeError: Cannot read property 'prototype' of undefined, js engine: hermes | |||
|
|||
This error occurs when trying to use Web3.js with React Native. To solve this error, use [the `react-native-quick-crypto` package](https://www.npmjs.com/package/react-native-quick-crypto). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@danforbes thanks, this is great! maybe also add mention that web3 has to be imported as a default import, as named import doesn't work. I tried to explain it here #7313 (comment)
import Web3 from 'web3';
862baa9
to
ebfdcd1
Compare
Closes #7314