Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Certificate Authority Generating tool to Crux #32

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Puneetha17
Copy link
Contributor

No description provided.

Copy link
Member

@conor10 conor10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - I'm interested to get your responses to my comments. The README will also need to be updated.

BasicConstraintsValid: true,
}

privateKey, err := rsa.GenerateKey(rand.Reader, 2048)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What flexibility is there for supporting other key types?

config.CertGetInt(config.ValidityYears),
config.CertGetInt(config.ValidityMonths),
config.CertGetInt(config.ValidityDays)),
IsCA: config.CertGetBool(config.IsCA),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's not a certificate authority, could we do signing on behalf of a local authority who's keys are on the same host? I appreciate this isn't exactly a production use case, but could be good to explore

import (
"crypto/rand"
"crypto/rsa"
"crypto/x509"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's cool that this is part of the standard library. We may want to split it out into a separate project or binary called crux-utils or similar. But I'd be interested to get your views.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants