-
Notifications
You must be signed in to change notification settings - Fork 550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of Contract::getEventLogs() and improved general comments and error messages #196
Open
Nanolucas
wants to merge
20
commits into
web3p:master
Choose a base branch
from
Nanolucas:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Dec 30, 2020
-
added and improved comments and error messages for clarity
Attempting to make some of the comments and errors easier to understand and clearer in what it does / what is required
Configuration menu - View commit details
-
Copy full SHA for dd25610 - Browse repository at this point
Copy the full SHA dd25610View commit details -
Configuration menu - View commit details
-
Copy full SHA for fd1c09b - Browse repository at this point
Copy the full SHA fd1c09bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 56b50e6 - Browse repository at this point
Copy the full SHA 56b50e6View commit details -
Configuration menu - View commit details
-
Copy full SHA for bffe4cf - Browse repository at this point
Copy the full SHA bffe4cfView commit details
Commits on Jan 2, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 486d849 - Browse repository at this point
Copy the full SHA 486d849View commit details -
Configuration menu - View commit details
-
Copy full SHA for 665b15b - Browse repository at this point
Copy the full SHA 665b15bView commit details -
Configuration menu - View commit details
-
Copy full SHA for af71b4d - Browse repository at this point
Copy the full SHA af71b4dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 121c80f - Browse repository at this point
Copy the full SHA 121c80fView commit details -
Configuration menu - View commit details
-
Copy full SHA for af3bd4c - Browse repository at this point
Copy the full SHA af3bd4cView commit details -
working implementation of getEventLogs
A working, improved and deciphered version of the function alluded to in web3p#93
Configuration menu - View commit details
-
Copy full SHA for 816c223 - Browse repository at this point
Copy the full SHA 816c223View commit details
Commits on Jan 3, 2021
-
also improve general comments throughout function
Configuration menu - View commit details
-
Copy full SHA for aade350 - Browse repository at this point
Copy the full SHA aade350View commit details -
Configuration menu - View commit details
-
Copy full SHA for 125aea0 - Browse repository at this point
Copy the full SHA 125aea0View commit details
Commits on Jan 9, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 46dc78e - Browse repository at this point
Copy the full SHA 46dc78eView commit details
Commits on Feb 21, 2021
-
Configuration menu - View commit details
-
Copy full SHA for bb9f9f0 - Browse repository at this point
Copy the full SHA bb9f9f0View commit details
Commits on Mar 17, 2021
-
Configuration menu - View commit details
-
Copy full SHA for b26da9a - Browse repository at this point
Copy the full SHA b26da9aView commit details
Commits on Mar 26, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 91ef36f - Browse repository at this point
Copy the full SHA 91ef36fView commit details -
Configuration menu - View commit details
-
Copy full SHA for d4e9e4a - Browse repository at this point
Copy the full SHA d4e9e4aView commit details
Commits on Apr 7, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 935e919 - Browse repository at this point
Copy the full SHA 935e919View commit details
Commits on Apr 17, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 87f8976 - Browse repository at this point
Copy the full SHA 87f8976View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0377c6c - Browse repository at this point
Copy the full SHA 0377c6cView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.