Refactor current_goal_state #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmmanuelAR
requested changes
Oct 29, 2024
bitfalt
requested changes
Oct 29, 2024
|
@bitfalt @EmmanuelAR I just made the requested changes, thanks for reviewing 👌 |
bitfalt
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Changes description
This PRs refactors the current_goal_state variable in favor of an ERC20 token balance.
The ERC20 token address has been added as a parameter of the fund to be able to create funds compatible with any ERC20 token.
The ongoing tests for withdraw might be impacted by this refactor.
Time spent breakdown
Half a day spent on reading the codebase, refactoring according to guidance and modifying tests accordingly.