Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip adding tx only legacy devices to registry #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jamesmelville
Copy link

Device Id for legacy devices is a tuple / list (e.g. device_id=[0x6C6C6, 0]) and breaks generating the dict

Device Id for legacy devices is a tuple / list (e.g. device_id=[0x6C6C6, 0]) and breaks generating the dict
@jamesmelville
Copy link
Author

Thanks for this code @webash - I've successfully connected up my MIHO008 light switch and MIHO032 motion sensor with mosquitto and openhab, and posted about it here https://community.openhab.org/t/energenie-mihome-api-help/21703/24. I just had to make this change to your code to make it work with my light switch which is a legacy device. I imagine there's better ways of doing this (inspecting the device object somehow to see what type it is?), but with my limited python experience this was the quickest way I found to get it working.

@webash
Copy link
Owner

webash commented Aug 27, 2020

Wow great to hear this was useful to you! I'm also not a python coder and have cobbled this together the best I can. I'll take a look at your PR and see if there's anything further that could be done.

@webash
Copy link
Owner

webash commented Sep 16, 2022

Oops. I have no idea why I didn't end up coming back to this... I'm still using this code but finally have Home Assistant setup properly to start doing something properly with the data beyond simple Node Red recipes.

@jamesmelville are you still using this code and did you modification help with what you use it for?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants