Add --defaults-file option to mysql/mysqldump #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mblaschke
added a commit
to webdevops/go-sync
that referenced
this pull request
Oct 3, 2017
Implement clitools feature “Add --defaults-file option to mysql/mysqldump“ webdevops/clitools#116
|
Wouldn't it be better to have some general options? Of you need other switches/parameters this can be defined as PS: already implemented in this way in https://github.com/webdevops/go-sync :) |
|
@mblaschke sure. But, as I already mentioned, this parameter needs to be the first one in order to work, whereas the |
mblaschke
added a commit
to webdevops/go-sync
that referenced
this pull request
Nov 2, 2017
|
@kitzberger can u review this PR? |
|
@josefglatz, what's the point in me reviewing the patch that I wrote? ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes it's not possible to place the .my.cnf file (containing the db password) into the users home folder on remote. So it'll be nice to specify a different location for that file.
The option mysql.mysqldump.options only works for mysqldump and not the mysql command that checks the db size and tablenames before syncing. Plus it doesn't add the --defaults-file option as first option which it needs to work properly.
So I introduced this option separately.