This repository has been archived by the owner on Dec 18, 2019. It is now read-only.
Update api.js #27
Open
Update api.js #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Convert '/' to '\' for file path
| @@ -148,6 +148,10 @@ exports.downloadRepository = function(req, res) { | |||
| */ | |||
| function(files, done) { | |||
| return async.map(files, function(file, cb) { | |||
| //Convert '/' to '\' | |||
There was a problem hiding this comment.
Perhaps a correct solution is to instead use something like path.join on the glob above.
Edit: https://github.com/isaacs/node-glob#windows
It looks like glob paths always need to be using forward slashes /, and glob internally returns paths made with path.join. I'm not sure why these slashes need to be converted to work on Windows.
I'm also uncomfortable with a regex based approach like this.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert '/' to '' for file path in windows file system.