Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: correct issue with getActionButton not finding the correct item #122

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

tylor-metrics
Copy link
Contributor

This may.. may.. be a resolution to an issue I was running into on B121.

I am not 100% certain I am identifying the correct root cause, so this change may be unwanted. Still testing things.

@tylor-metrics tylor-metrics changed the title correct issue with getActionButton not finding the correct item bug: correct issue with getActionButton not finding the correct item Jun 12, 2024
Copy link
Contributor

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call 👍 I was assuming that actions would be an WebdriverIO.ElementArray which would support async iterators but getActionButtons actually returns an array.

Nice find!

Please let me know if this resolves the issue after the release.

@christian-bromann christian-bromann merged commit b0c30a3 into webdriverio-community:main Jun 13, 2024
3 of 9 checks passed
@wdio-bot
Copy link
Collaborator

Hey tylor-metrics 👋

Thank you for your contribution to WebdriverIO! Your pull request has been marked as an "Expensable" contribution. We've sent you an email with further instructions on how to claim your expenses from our development fund. Please make sure to check your spam folder as well. If you have any questions, feel free to reach out to us at [email protected] or in the contributing channel on Discord.

We are looking forward to more contributions from you in the future 🙌

Have a nice day,
The WebdriverIO Team 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants