Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for drupal-composer-helper plugin #33

Closed
wants to merge 3 commits into from

Conversation

hussainweb
Copy link

The new drupal-composer-helper plugin aims to reduce complexity in setting up and maintaining Drupal sites based on composer. As one of its improvements, it removes the necessity of explicitly specifying installer-paths in extra section of composer.json (it's still supported but not necessary). Unfortunately, this breaks tools like drush and drupal console as indicated in hussainweb/drupal-composer-helper#9.

I have outlined a workaround in that issue and I am trying to add support to drupal-finder to detect sites based on drupal-composer-helper plugin. I have tested this fix on my local install and it fixes the problem mentioned in hussainweb/drupal-composer-helper#9.

@webflo
Copy link
Owner

webflo commented Oct 24, 2017

Is it possible to use more generic configuration options? Similar to symfony-standard? https://github.com/symfony/symfony-standard/blob/3.3/composer.json#L55

@hussainweb
Copy link
Author

In hindsight, web-dir sounds better than web-prefix. I'm worried about backward compatibility though. What would you suggest?

hussainweb added a commit to hussainweb/drupal-composer-init that referenced this pull request Oct 27, 2017
…finder

As seen in hussainweb/drupal-composer-helper#9 , drupal-finder relies on the installer-paths section to determine the Drupal installation location. A proper fix is suggested in webflo/drupal-finder#33 but until then, this will serve as a workaround.
@hussainweb
Copy link
Author

@webflo, please let me know if there is something I can do to speed this up. :)

@webflo
Copy link
Owner

webflo commented Oct 27, 2017

@hussainweb How about drupal-web-dir?

@hussainweb
Copy link
Author

@webflo, sounds good. I still think I should nest it within drupal-composer-helper so that all settings stay together. Also, I will still have to handle both versions in code at least or existing composer.json files will break. Thoughts?

@hussainweb
Copy link
Author

I have been thinking about this, well, since a long time now 😄, and think that drupal-web-dir is a good name. It makes sense to put it under extra directly. I just pushed my changes. I will also be making changes in my repository.

@hussainweb
Copy link
Author

I might be wrong but the Travis build seems random (the error is due to phpenv failing. I don't have rights to rerun the build.

@hussainweb
Copy link
Author

FWIW, I have tagged a new release of drupal-composer-helper that would use this setting.

@hussainweb
Copy link
Author

Closing in favour of #49

@hussainweb hussainweb closed this Feb 11, 2020
@hussainweb hussainweb deleted the dc-helper-support branch February 11, 2020 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants