-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for drupal-composer-helper plugin #33
Conversation
Is it possible to use more generic configuration options? Similar to symfony-standard? https://github.com/symfony/symfony-standard/blob/3.3/composer.json#L55 |
In hindsight, |
…finder As seen in hussainweb/drupal-composer-helper#9 , drupal-finder relies on the installer-paths section to determine the Drupal installation location. A proper fix is suggested in webflo/drupal-finder#33 but until then, this will serve as a workaround.
@webflo, please let me know if there is something I can do to speed this up. :) |
@hussainweb How about |
@webflo, sounds good. I still think I should nest it within |
I have been thinking about this, well, since a long time now 😄, and think that |
I might be wrong but the Travis build seems random (the error is due to |
FWIW, I have tagged a new release of drupal-composer-helper that would use this setting. |
Closing in favour of #49 |
The new drupal-composer-helper plugin aims to reduce complexity in setting up and maintaining Drupal sites based on composer. As one of its improvements, it removes the necessity of explicitly specifying
installer-paths
inextra
section ofcomposer.json
(it's still supported but not necessary). Unfortunately, this breaks tools like drush and drupal console as indicated in hussainweb/drupal-composer-helper#9.I have outlined a workaround in that issue and I am trying to add support to drupal-finder to detect sites based on drupal-composer-helper plugin. I have tested this fix on my local install and it fixes the problem mentioned in hussainweb/drupal-composer-helper#9.