Make drupal-finder use the same priority order that composer/installers does when reading installer-paths #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg-1-anderson
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem statement:
drupal-finderhas the reverse priority order for installer-paths thatcomposer/installershas. This is a problem in a degenerate case, where a site has two entries fortype:drupal-core.composer/installerswill take the first entry, installing Drupal toweb/coredrupal-finderuses the second entry, causing Drush to look for Drupal incoreinstead ofweb/coreSince neither project complains about the duplicate entry, this can cause some head-scratching if the humans don't notice that there's more than one
type:drupal-corein the long installer-paths list.Proposed Solution:
There are two choices:
drupal-finderinterpretinstaller-pathsthe same way thatcomposer/installersdoes.Since humans are fallible, and there are a lot of Drupal sites, I would prefer to go with the second option.