Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(terraform): add Terraform package #524

Merged
merged 2 commits into from
Oct 16, 2023

Conversation

jclicodes
Copy link
Contributor

Closes webinstall/webi-installer-requests#36.

Added Terraform as a package. It requests all releases from https://releases.hashicorp.com/terraform/index.json

Passed the test in _webi/test.js.

I can confirm it is working on both of my systems (macos/arm64 and windows/amd64), see below for output.

macos/arm64:

sh install-terraform.sh

Thanks for using webi to install 'terraform' on 'Darwin/arm64'.
Have a problem? Experience a bug? Please let us know:
        https://github.com/webinstall/webi-installers/issues

Lovin' it? Say thanks with a Star on GitHub:
        https://github.com/webinstall/webi-installers

Downloading terraform from
https://releases.hashicorp.com/terraform/1.3.2/terraform_1.3.2_darwin_arm64.zip

Saved as /Users/jcli/Downloads/webi/terraform/1.3.2/terraform_1.3.2_darwin_arm64.zip
Extracting /Users/jcli/Downloads/webi/terraform/1.3.2/terraform_1.3.2_darwin_arm64.zip
Installing to /Users/jcli/.local/opt/terraform-v1.3.2/bin/terraform
Installed 'terraform v1.3.2' as /Users/jcli/.local/bin/terraform

windows/amd64:

Set-ExecutionPolicy Bypass -Scope Process -Force; [System.Net.ServicePointManager]::SecurityProtocol = [System.Net.ServicePointManager]::SecurityProtocol -bor 3072; powershell.exe .\install-terraform.ps1
PATH not changed.

Downloading terraform from https://releases.hashicorp.com/terraform/1.3.2/terraform_1.3.2_windows_amd64.zip to C:\Users\jakec\Downloads\webi\terraform_1.3.2_windows_amd64.zip
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 11.7M  100 11.7M    0     0  3284k      0  0:00:03  0:00:03 --:--:-- 3285k
Installing terraform
Unpacking C:\Users\jakec\Downloads\webi\terraform_1.3.2_windows_amd64.zip
Install Location: C:\Users\jakec.local\opt\terraform-v1.3.2\bin\terraform.exe
Copying into 'C:\Users\jakec.local\bin\terraform.exe' from 'C:\Users\jakec.local\opt\terraform-v1.3.2\bin\terraform.exe'

C:\ terraform -v
Terraform v1.3.2

@jclicodes
Copy link
Contributor Author

Hi, @coolaj86 @ryanburnette, would you mind reviewing this when you get a chance? Thanks

Copy link
Member

@ryanburnette ryanburnette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Any feedback from @coolaj86?

@y0rune
Copy link
Collaborator

y0rune commented Jan 15, 2023

LGTM too! Thank you @J-Curragh ;) What do you think @coolaj86?

@coolaj86 coolaj86 force-pushed the terraform-package branch 2 times, most recently from a2f5b8f to 395f58b Compare October 16, 2023 20:04
Copy link
Member

@coolaj86 coolaj86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@J-Curragh My apologies for letting this go so long. You did everything right and I can tell you put above-average effort into this.

I think I just got distracted and confused on the day I looked at this and never got back to it. 😞

The consolation prize is that it makes it in today. 🎉

And as a standard offer to all contributors: If you drop or DM me your Đash Wallet address here I'll be more than happy to send a tip / buy you lunch.

Again, many apologies and many thanks.

@coolaj86 coolaj86 merged commit aa616be into webinstall:main Oct 16, 2023
3 checks passed
@jclicodes
Copy link
Contributor Author

@J-Curragh My apologies for letting this go so long. You did everything right and I can tell you put above-average effort into this.

I think I just got distracted and confused on the day I looked at this and never got back to it. 😞

The consolation prize is that it makes it in today. 🎉

And as a standard offer to all contributors: If you drop or DM me your Đash Wallet address here I'll be more than happy to send a tip / buy you lunch.

Again, many apologies and many thanks.

Hey, thanks for getting this merged in, it's my first FOSS contribution ✨
I just appreciate the opportunity ❤️ cool project!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add terraform
4 participants