-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(terraform): add Terraform package #524
Conversation
Hi, @coolaj86 @ryanburnette, would you mind reviewing this when you get a chance? Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Any feedback from @coolaj86?
LGTM too! Thank you @J-Curragh ;) What do you think @coolaj86? |
9f03446
to
e349978
Compare
a2f5b8f
to
395f58b
Compare
395f58b
to
aa616be
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@J-Curragh My apologies for letting this go so long. You did everything right and I can tell you put above-average effort into this.
I think I just got distracted and confused on the day I looked at this and never got back to it. 😞
The consolation prize is that it makes it in today. 🎉
And as a standard offer to all contributors: If you drop or DM me your Đash Wallet address here I'll be more than happy to send a tip / buy you lunch.
Again, many apologies and many thanks.
Hey, thanks for getting this merged in, it's my first FOSS contribution ✨ |
Closes webinstall/webi-installer-requests#36.
Added Terraform as a package. It requests all releases from https://releases.hashicorp.com/terraform/index.json
Passed the test in
_webi/test.js
.I can confirm it is working on both of my systems (macos/arm64 and windows/amd64), see below for output.
macos/arm64:
windows/amd64: