Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix+lint release targets #765

Merged
merged 11 commits into from
Nov 16, 2023
Merged

fix+lint release targets #765

merged 11 commits into from
Nov 16, 2023

Conversation

coolaj86
Copy link
Member

While working on #756 I discovered

  • erroneous releases that cannot be matched generically
  • some version numbers that don't match the file path

This updates those release files to produce clean outputs.

@coolaj86 coolaj86 requested a review from HacDan November 16, 2023 04:32
jojobyte
jojobyte approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@jojobyte jojobyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@coolaj86 coolaj86 merged commit 286efb7 into main Nov 16, 2023
@coolaj86 coolaj86 deleted the lint-release-targets-2 branch November 16, 2023 04:38
@coolaj86
Copy link
Member Author

Note: I had to put a hotfix into prod so that the default release is amd64 for flutter until #756 is ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jojobyte jojobyte jojobyte approved these changes

@HacDan HacDan Awaiting requested review from HacDan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@coolaj86 @jojobyte