fix!(chromedriver): rewrite for latest releases URL #766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coolaj86
force-pushed
the
fix-chromedriver
branch
2 times, most recently
from
fd7406c to
552b924
Compare
coolaj86
force-pushed
the
fix-chromedriver
branch
from
552b924 to
993e2dd
Compare
Nothing really. No one is using this. We know this because it's over a year out of date and no one has reported it. 🙃 But I did just test it on all 3 major OSes just to be safe. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been using an outdated release URL that's missing over a year of releases.
The new one is json, so it's much simpler.
This is a complete replacement and it passes the linter being built in #756.
(in fact, that's why this issue was discovered)
How to test
curl https://next.webinstall.dev/chromedriver | sh chromedriver --version