Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Replace whoami with id -u -n in scripts for POSIX compliance (#854) #915

Merged
merged 2 commits into from
Dec 15, 2024

Conversation

shuchitpant
Copy link

This PR addresses issue #854 by replacing all instances of the whoami command with id -u -n, aligning with the POSIX standard for guaranteed behavior across Unix-like systems.

Changes Made:

  • Conducted a find-and-replace for whoami across relevant scripts and documentation files.
  • Verified using grep that no remaining whoami instances exist within the repository.

This simple refactor improves cross-platform compatibility, following best practices as outlined in the issue description.

Copy link
Member

@coolaj86 coolaj86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I edited the commit to remove some junk temporary files that were mistakenly committed. Other than that, great.

Thank you!

@coolaj86 coolaj86 merged commit d6fc5ce into webinstall:main Dec 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants