Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

partial refactor for files regarding the ISSUE#898 request to fetch #919

Merged
merged 8 commits into from
Dec 16, 2024

Conversation

MichalTirpak
Copy link
Contributor

This pull request addresses Issue #898 by partially refactoring the mentioned files to replace the use of the request method with fetch.
The refactor is marked as partial because:

  • There is an issue with releases.js for MariaDB.
  • Specifically, the payload does not include the expected MariaDB package releases.
  • This issue is present in the original implementation.

@coolaj86 coolaj86 force-pushed the ref-request-with-fetch branch from a093489 to 51d7c6f Compare December 15, 2024 06:51
@coolaj86 coolaj86 force-pushed the ref-request-with-fetch branch 2 times, most recently from c3f7c61 to c7ace75 Compare December 15, 2024 08:24
Copy link

socket-security bot commented Dec 15, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] environment, filesystem 0 75.8 kB motdotla
npm/[email protected] None 0 957 kB tonybrix

🚮 Removed packages: npm/@root/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

@coolaj86
Copy link
Member

I still have some testing to do to make sure that everything still works and I didn't mess anything up with my additional refactor work here, but this is on track to make it in within a few days.

Thanks for your work on this.

@coolaj86
Copy link
Member

coolaj86 commented Dec 15, 2024

Needs testing on https://beta.webinstall.dev/

macOS

  • chromedriver
  • flutter
  • go
  • gpg
  • iterm2
  • julia
  • node
  • terraform
  • zig

Linux

  • flutter
  • go
  • gpg (N/A)
  • node
  • terraform
  • zig

Tested that the macos downloader works, but it's a legacy (pre-M1) script to build a macos installer, so... it's on the out anyway.

Copy link
Member

@coolaj86 coolaj86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and everything is looking good and working as expected.

@coolaj86 coolaj86 force-pushed the ref-request-with-fetch branch from 15271c2 to f1d1027 Compare December 16, 2024 00:20
@coolaj86 coolaj86 merged commit 6320c51 into webinstall:main Dec 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants