Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(api): 'alias' projects (symlinks) should be resolved before checking for 'selfhosted' #934

Merged
merged 1 commit into from
Dec 16, 2024
Merged

fix(api): 'alias' projects (symlinks) should be resolved before checking for 'selfhosted' #934

merged 1 commit into from
Dec 16, 2024
+7 −5

Conversation

coolaj86
Copy link
Member

fixes #933

Projects are marked as an alias if they're a symlink, or if alias: is matched in the first 1k of of the README.md.

Excluding possible errors, the resolved projects are either valid (having a releases.js) or selfhosted (having an install.sh and local files committed to Webi, no remote releases).

Up to this point alias projects have simply been cached twice. However, vim-mouse is a symlink alias of vim-gui, which has no releases.js and was therefore failing module resolution (as it didn't match selfhosted).

This change resolves alias projects before checking if they're valid or selfhosted.

@coolaj86 coolaj86 changed the title fix(api): project 'alias'es (symlinks) should be resolved before checking for 'selfhosted' fix(api): 'alias' projects (symlinks) should be resolved before checking for 'selfhosted' Dec 15, 2024
@coolaj86 coolaj86 mentioned this pull request Dec 15, 2024
Closed
jojobyte
jojobyte approved these changes Dec 15, 2024
View reviewed changes
Copy link
Contributor

@jojobyte jojobyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay but do you want the console debugs still in there?

@coolaj86 coolaj86 force-pushed the fix-selfhosted-symlink-alias branch from de2d391 to 83a6d02 Compare December 16, 2024 01:02
@coolaj86 coolaj86 merged commit 83a6d02 into main Dec 16, 2024
3 checks passed
@coolaj86 coolaj86 deleted the fix-selfhosted-symlink-alias branch December 16, 2024 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jojobyte jojobyte jojobyte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

problem with vim-gui installer
2 participants
@coolaj86 @jojobyte