Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(serviceman) don't use sudo / env PATH= #937

Merged
merged 2 commits into from
Dec 16, 2024
Merged

fix(serviceman) don't use sudo / env PATH= #937

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7b8f882
fix(serviceman): do not use 'sudo' or 'env PATH="$PATH"'
coolaj86 Dec 16, 2024
4eff5b6
doc(syncthing): 'env PATH=' is no longer needed for serviceman
coolaj86 Dec 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion brew/brew-update-service-install
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ main() { (
fi
serviceman --version

env PATH="$PATH" serviceman add --agent \
serviceman add --agent \
--workdir ~/.local/opt/brew/ \
--name sh.brew.updater -- \
~/.local/bin/brew-update-hourly
Expand Down
3 changes: 1 addition & 2 deletions dashcore-utils/dashd-hd-service-install
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,8 +119,7 @@ fn_srv_install() { (
cd "${my_vol}" || return 1
# leave options unquoted so they're interpreted separately
# shellcheck disable=SC2086
sudo env PATH="${PATH}" \
serviceman add --name "${my_name}" -- \
serviceman add --name "${my_name}" -- \
dashd \
${my_net_flag} \
-usehd \
Expand Down
2 changes: 1 addition & 1 deletion syncthing/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ webi serviceman

```sh
mkdir -p ~/.config/syncthing/
env PATH="$PATH" serviceman add --agent --name syncthing -- \
serviceman add --agent --name syncthing -- \
syncthing --home ~/.config/syncthing/
```

Expand Down
Loading