Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump com.fasterxml.jackson.core:jackson-core from 2.15.2 to 2.16.1 #137

Conversation

dependabot[bot]
Copy link

@dependabot dependabot bot commented on behalf of github Dec 26, 2023

Bumps com.fasterxml.jackson.core:jackson-core from 2.15.2 to 2.16.1.

Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

Bumps [com.fasterxml.jackson.core:jackson-core](https://github.com/FasterXML/jackson-core) from 2.15.2 to 2.16.1.
- [Release notes](https://github.com/FasterXML/jackson-core/releases)
- [Commits](FasterXML/jackson-core@jackson-core-2.15.2...jackson-core-2.16.1)

---
updated-dependencies:
- dependency-name: com.fasterxml.jackson.core:jackson-core
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Dec 26, 2023
@jamesward
Copy link
Member

@mkurz I'm wondering if there is a way we could better organize things to avoid incompat with Play's Jackson version. We could try to move https://github.com/webjars/webjars-locator-core/blob/main/src/main/java/org/webjars/WebJarExtractor.java to https://github.com/webjars/webjars-play
My hunch is that only sbt-web / Play are the only real consumers of that API anyway. WDYT?

Copy link
Author

dependabot bot commented on behalf of github Mar 11, 2024

Superseded by #145.

@dependabot dependabot bot closed this Mar 11, 2024
@dependabot dependabot bot deleted the dependabot/maven/com.fasterxml.jackson.core-jackson-core-2.16.1 branch March 11, 2024 01:20
@mkurz
Copy link

mkurz commented Mar 11, 2024

@mkurz I'm wondering if there is a way we could better organize things to avoid incompat with Play's Jackson version. We could try to move https://github.com/webjars/webjars-locator-core/blob/main/src/main/java/org/webjars/WebJarExtractor.java to https://github.com/webjars/webjars-play My hunch is that only sbt-web / Play are the only real consumers of that API anyway. WDYT?

@jamesward That does not really work, because Play by default uses webjars-locator-core, but not webjars-play:
https://github.com/playframework/playframework/blob/3.0.2/project/plugins.sbt#L39

The webjars-play project is a nice helper project but not included into Play core.

@jamesward Actually, I just checked once more and we are OK to merge the latest jackson releases into webjars-locator-core because Play uses it it for sbt plugins (in the "meta build" in the project folder), so it does not interfere with the jackson version we pull in in the project's librarydependencies itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants