Lending system frontend #4219

eikhr · 2023-10-20T10:56:15Z

Description

Result

Testing

I have thoroughly tested my changes.

Please describe what and how the changes have been tested, and provide instructions to reproduce if necessary.

Resolves ABA-613

linear · 2023-10-20T10:56:19Z

ABA-613 Lending system

Backup has requested a lending system, as Abakus has a lot of objects that could be lent out to Ababeads if we just had a good system for it. Arrkom also wants this system to make it easier to administrate Soundboks and grill lending.

ivarnakken

I get that it's a WIP but I'm bored

app/routes/lending/LendableObjectsList.css

app/routes/lending/LendableObjectsAdmin.css

app/routes/lending/LendableObjectEdit.tsx

app/routes/lending/LendableObjectDetail.tsx

app/routes/lending/LendableObjectAdminDetail.tsx

eikhr · 2023-10-20T16:13:16Z

Haha, It's very WIP. How do you think we should do the colors in the calendar? I'm not sure if css variables work there, but now that I think of it I don't believe we tried🤔

app/styles/globals.css

app/routes/lending/LendableObjectEdit.tsx

app/routes/lending/LendableObjectDetail.tsx

app/routes/lending/LendableObjectAdminDetail.tsx

package.json

app/actions/LendableObjectActions.ts

app/actions/ActionTypes.ts

app/routes/lending/LendableObjectsList.css

app/routes/lending/LendableObjectsAdmin.css

app/routes/lending/LendableObjectsList.tsx

ivarnakken

Thought I'd give another review on this hehe

app/routes/lending/LendableObjectEdit.tsx

package.json

app/routes/lending/LendableObjectsAdmin.css

app/routes/lending/LendableObjectsList.tsx

ivarnakken

Here you go

app/routes/index.tsx

app/store/models/LendableObject.d.ts

app/styles/globals.css

app/routes/lending/index.tsx

app/routes/lending/LendableObjectsList.tsx

app/actions/LendableObjectActions.ts

app/routes/lending/LendableObjectsList.css

app/routes/lending/components/LendingRequest.css

app/routes/lending/components/LendingRequest.tsx

app/store/models/LendableObject.d.ts

app/routes/lending/LendableObjectsAdmin.tsx

app/routes/lending/components/LendingRequest.tsx

app/routes/lending/LendableObjectsList.tsx

app/routes/lending/components/LendingRequest.tsx

app/routes/lending/LendableObjectsList.tsx

itsisak · 2024-04-30T10:55:39Z

This system does not seem to support contracts, like I know Arrkom uses when lending stuff out. I don't think we need to upload contracts for each object, but there should be some responsibility acknowledgement info and button or something. Talk to Arrkom about how they would like this

I think the plan was to add some support for contracts, but we can consider a different approach, like you suggest. For now we want to finalize the current functionality and get it merged to master (but disable link to this page) and then iterate on further funtionality like this later in order to avoid to much rebasing and try and get a mvp working.

app/actions/LendingRequestActions.ts

app/components/Search/utils.tsx

ivarnakken · 2024-04-30T20:24:01Z

app/routes/lending/components/LendableObjectAdminDetail.tsx

+import type { Params } from 'react-router-dom';
+
+const LendableObjectAdminDetail = () => {
+  const { lendableObjectId } = useParams<Params>();


Not resolved

app/routes/lending/components/LendableObjectEdit.tsx

app/routes/lending/components/LendableObjectsList.tsx

app/routes/lending/components/LendingAdmin.tsx

app/routes/lending/components/LendingRequestAdmin.tsx

app/store/models/LendingRequest.ts

app/routes/lending/components/LendableObjectEdit.tsx

This reverts commit f1ff1f1.

ivarnakken

@Bestem0r I see that a lot of comments here have been set as resolved without any changes. Have you pushed everything?

app/routes/lending/components/LendingRequestAdmin.tsx

app/routes/lending/components/LendingRequest.tsx

app/routes/lending/components/LendingAdmin.tsx

ivarnakken

Awesome work guys! 😄 I think this is looking really good - sorry for all the nitpicking. We should probably merge it in (squashed) as soon as possible! 🥳

vercel · 2024-07-05T20:26:25Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
lego-bricks-storybook	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 15, 2024 5:46pm

eikhr · 2024-07-06T12:48:43Z

Can we merge this? @itsisak @Bestem0r

Bestem0r · 2024-07-06T12:54:30Z

Can we merge this? @itsisak @Bestem0r

It should be good, but the backend is not yet ready @eikhr

eikhr · 2024-07-06T12:55:29Z

Can we merge this? @itsisak @Bestem0r

It should be good, but the backend is not yet ready @eikhr

What's missing from the backend?

Bestem0r · 2024-07-06T13:01:09Z

Can we merge this? @itsisak @Bestem0r

It should be good, but the backend is not yet ready @eikhr

What's missing from the backend?

As far as I know, only fixing the requested changes and merging it

github-actions bot added the review-needed Pull requests that need review label Oct 20, 2023

eikhr force-pushed the lending-system branch 2 times, most recently from 5a81cca to 96b9d4f Compare October 20, 2023 13:15

ivarnakken requested changes Oct 20, 2023

View reviewed changes

ivarnakken reviewed Oct 22, 2023

View reviewed changes

eikhr force-pushed the lending-system branch from 96b9d4f to 2db4fe2 Compare November 7, 2023 18:44

ivarnakken reviewed Nov 7, 2023

View reviewed changes

app/routes/lending/LendableObjectsList.css Outdated Show resolved Hide resolved

app/routes/lending/LendableObjectsAdmin.css Outdated Show resolved Hide resolved

app/routes/lending/LendableObjectsList.tsx Outdated Show resolved Hide resolved

ivarnakken added do-not-merge/WIP Pull requests that are "work in progress", and should not be merged new-feature Pull requests that introduce a new feature changes-requested Pull requests with requested changes labels Nov 7, 2023

ivarnakken reviewed Feb 1, 2024

View reviewed changes

ivarnakken added priority:high Pull requests that have high priority, and should therefore be prioritized need-before-2050 Pull requests that have been in progress for far too long labels Feb 1, 2024

ivarnakken reviewed Feb 2, 2024

View reviewed changes

ivarnakken reviewed Feb 4, 2024

View reviewed changes

app/routes/lending/LendableObjectsList.tsx Outdated Show resolved Hide resolved

app/routes/lending/components/LendingRequest.tsx Outdated Show resolved Hide resolved

app/routes/lending/LendableObjectsList.tsx Outdated Show resolved Hide resolved

eikhr and others added 12 commits February 4, 2024 13:48

WIP

51f8221

Add form modal on lending object page and start on admin page

7b589cd

Add redux actions and form for creating lendable objects

5cfa8cd

Change Card and Modal imports to use lego-bricks

04cc608

Fix most comments

c442c61

Replace custom header style with header tag

c87c0c2

Remove unnecessary commenting

8e580ba

Add navigation to request approval

28637fe

Remove form spy debug

87c872f

Replace browse button with edit button

da0a464

Add buttons to create and approve objects

de8e4bd

Graphical interface for admin and "my requests"

3cc46e9

Bestem0r and others added 3 commits April 30, 2024 20:23

Fix a ton of comments

81f5fc9

Type LendableObjectEdit form

1617206

Add skeleton, reformat with prettier

b9a1543

Bestem0r marked this pull request as ready for review April 30, 2024 20:20

ivarnakken reviewed Apr 30, 2024

View reviewed changes

app/routes/lending/components/LendableObjectEdit.tsx Outdated Show resolved Hide resolved

app/routes/lending/components/LendableObjectEdit.tsx Outdated Show resolved Hide resolved

Bestem0r and others added 5 commits May 1, 2024 18:43

Fix comments

c47812e

Fix lending admin style and bugs, remove global td styling in bricks

e99b378

Remove unnecessary type 'Params'

f1ff1f1

Revert "Remove unnecessary type 'Params'"

ba663a9

This reverts commit f1ff1f1.

Properly type Params

7d09e24

ivarnakken reviewed May 6, 2024

View reviewed changes

app/routes/lending/components/LendingRequestAdmin.tsx Outdated Show resolved Hide resolved

app/routes/lending/components/LendingRequest.tsx Outdated Show resolved Hide resolved

app/routes/lending/components/LendingAdmin.tsx Outdated Show resolved Hide resolved

Fix comments

2506bda

ivarnakken approved these changes May 10, 2024

View reviewed changes

eikhr added 2 commits July 4, 2024 19:58

Merge branch 'master' into lending-system

d4e091a

Update for new page layout components

0af454b

vercel bot temporarily deployed to Preview July 6, 2024 12:51 Inactive

Merge branch 'master' into lending-system

e597802

eikhr force-pushed the lending-system branch from 2bbf7f5 to e597802 Compare July 15, 2024 17:44

vercel bot temporarily deployed to Preview July 15, 2024 17:46 Inactive

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Lending system frontend #4219

Lending system frontend #4219

eikhr commented Oct 20, 2023

linear bot commented Oct 20, 2023

ivarnakken left a comment

eikhr commented Oct 20, 2023

ivarnakken left a comment

ivarnakken left a comment

itsisak commented Apr 30, 2024

ivarnakken Apr 30, 2024

ivarnakken left a comment

ivarnakken left a comment •

edited

Loading

vercel bot commented Jul 5, 2024 •

edited

Loading

eikhr commented Jul 6, 2024

Bestem0r commented Jul 6, 2024

eikhr commented Jul 6, 2024

Bestem0r commented Jul 6, 2024 •

edited

Loading

Lending system frontend #4219

Are you sure you want to change the base?

Lending system frontend #4219

Conversation

eikhr commented Oct 20, 2023

Description

Result

Testing

linear bot commented Oct 20, 2023

ivarnakken left a comment

Choose a reason for hiding this comment

eikhr commented Oct 20, 2023

ivarnakken left a comment

Choose a reason for hiding this comment

ivarnakken left a comment

Choose a reason for hiding this comment

itsisak commented Apr 30, 2024

ivarnakken Apr 30, 2024

Choose a reason for hiding this comment

ivarnakken left a comment

Choose a reason for hiding this comment

ivarnakken left a comment • edited Loading

Choose a reason for hiding this comment

vercel bot commented Jul 5, 2024 • edited Loading

eikhr commented Jul 6, 2024

Bestem0r commented Jul 6, 2024

eikhr commented Jul 6, 2024

Bestem0r commented Jul 6, 2024 • edited Loading

ivarnakken left a comment •

edited

Loading

vercel bot commented Jul 5, 2024 •

edited

Loading

Bestem0r commented Jul 6, 2024 •

edited

Loading