Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add genfors count achievement #5374

Merged
merged 1 commit into from
Feb 25, 2025
Merged

Add genfors count achievement #5374

merged 1 commit into from
Feb 25, 2025
+32 −0

Conversation

Arashfa0301
Copy link
Contributor

@Arashfa0301 Arashfa0301 commented Feb 24, 2025 •
edited
Loading

Description

Added an achievement for the number of "genfors" events one has attended. Open to suggestions for better rarity names.

@vercel Vercel
Copy link

vercel bot commented Feb 24, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
lego-bricks-storybook ⬜️ Ignored (Inspect) Visit Preview Feb 25, 2025 0:24am

@github-actions github-actions bot added the review-needed Pull requests that need review label Feb 24, 2025
@Arashfa0301 Arashfa0301 force-pushed the add-genfors-achievement branch from 813fed1 to 236d907 Compare February 24, 2025 16:40
ch0rizo
ch0rizo reviewed Feb 25, 2025
View reviewed changes
Copy link
Contributor

@ch0rizo ch0rizo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with Jonas on the rarity lvls

@Arashfa0301 Arashfa0301 force-pushed the add-genfors-achievement branch from 236d907 to 21d6eb0 Compare February 25, 2025 12:09
jonasdeluna
jonasdeluna requested changes Feb 25, 2025
View reviewed changes
@Arashfa0301 Arashfa0301 force-pushed the add-genfors-achievement branch from 21d6eb0 to 8b0ac67 Compare February 25, 2025 12:23
jonasdeluna
jonasdeluna approved these changes Feb 25, 2025
View reviewed changes
Copy link
Member

@jonasdeluna jonasdeluna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, works for now I think we can rework the names later 👍

@Arashfa0301 Arashfa0301 merged commit a70cb92 into master Feb 25, 2025
8 checks passed
@Arashfa0301 Arashfa0301 deleted the add-genfors-achievement branch February 25, 2025 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonasdeluna jonasdeluna jonasdeluna approved these changes

@ch0rizo ch0rizo ch0rizo approved these changes

@eikhr eikhr Awaiting requested review from eikhr

@norbye norbye Awaiting requested review from norbye

@ivarnakken ivarnakken Awaiting requested review from ivarnakken

Assignees
No one assigned
Labels
review-needed Pull requests that need review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Arashfa0301 @jonasdeluna @ch0rizo