Remove admin_comment from company #3643
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [twisted](https://github.com/twisted/twisted) from 22.10.0 to 24.7.0. - [Release notes](https://github.com/twisted/twisted/releases) - [Changelog](https://github.com/twisted/twisted/blob/trunk/NEWS.rst) - [Commits](twisted/twisted@twisted-22.10.0...twisted-24.7.0) --- updated-dependencies: - dependency-name: twisted dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
juniwbjerde
force-pushed
the
remove-adminComment-from-companies
branch
from
e518c18 to
cfa6fed
Compare
ivarnakken
reviewed
Sep 25, 2024
ivarnakken
added
discussion
|
@ivarnakken I talked to Falk about it, and his impression after talking to Bedkom was that they didn't use it. I don't see why we would need both the admin_comment field as well as normal comments on companies. It's just a bit messy in my opinion, and there's nothing you would write in the admin comment that wouldn't fit just as well as a normal comment (in my opinion). And with normal comments you get the date it was written as well, so that you can more easily see if it's updated info or not. Espescially when we don't just delete the data in the admin_comment field completely, but rather mighrated it to a comment, I feel like it is completly fine. I don't have access to to itDAGENES admin page, how do they do it? |
juniwbjerde
force-pushed
the
remove-adminComment-from-companies
branch
from
cfa6fed to
2948c1d
Compare
…timestamp Add company contact update timestamp
Well, almost unused. Replaced the usage in the response of reset_password with CurrentUserSerializer
…alizer Remove unused DetailedUserSerializer
Bumps [django-cors-headers](https://github.com/adamchainz/django-cors-headers) from 3.14.0 to 4.5.0. - [Changelog](https://github.com/adamchainz/django-cors-headers/blob/main/CHANGELOG.rst) - [Commits](adamchainz/django-cors-headers@3.14.0...4.5.0) --- updated-dependencies: - dependency-name: django-cors-headers dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [django-redis](https://github.com/jazzband/django-redis) from 5.2.0 to 5.4.0. - [Release notes](https://github.com/jazzband/django-redis/releases) - [Changelog](https://github.com/jazzband/django-redis/blob/master/CHANGELOG.rst) - [Commits](jazzband/django-redis@5.2.0...5.4.0) --- updated-dependencies: - dependency-name: django-redis dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Bump django-redis from 5.2.0 to 5.4.0
Bumps [black](https://github.com/psf/black) from 24.8.0 to 24.10.0. - [Release notes](https://github.com/psf/black/releases) - [Changelog](https://github.com/psf/black/blob/main/CHANGES.md) - [Commits](psf/black@24.8.0...24.10.0) --- updated-dependencies: - dependency-name: black dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [django](https://github.com/django/django) from 4.0.10 to 4.2.16. - [Commits](django/django@4.0.10...4.2.16) --- updated-dependencies: - dependency-name: django dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
Fix external sync for google
Not sure why this was removed hehe
…ers-are-not-shown-on-old-events
…ltering-on-companies
Bumps [jinja2](https://github.com/pallets/jinja) from 3.1.4 to 3.1.5. - [Release notes](https://github.com/pallets/jinja/releases) - [Changelog](https://github.com/pallets/jinja/blob/main/CHANGES.rst) - [Commits](pallets/jinja@3.1.4...3.1.5) --- updated-dependencies: - dependency-name: jinja2 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
* Add pagination, ordering to AdminCompanyViewSet * Format code * Add migrations
Change announcement message title
…ng-meetings Prevent admins from searching meetings
Improve feedback for abacard responses
Add readme to image before running install
Lock poetry version to 1.8.5
* Add leaderboard for overall score * Update achievement score, make percentage cached * Update achievement_score * Implement pagination achievements * Fix tests
…es' into remove-adminComment-from-companies # Conflicts: # lego/apps/companies/serializers.py
|
Welp. I kinda messed up this PR in order to hijack it and get it merged.... 😅 |
|
I might actually die if this is not squashed |
|
Actually, no, do not merge this before fixing the commits. |
|
I think he recreated it in #3727, so this PR could be closed and abandoned |
|
ah i didnt catch that haha - nice then! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the field admin_comment from the company model. It was never really used...
I also wrote a custom data migration to make a normal comment on the company with the admin_comment (in case any of the admin_comments were actually useful and shouldn't be totally deleted
Corresponding frontend changes: webkom/lego-webapp#5001
Resolves ABA-1052