bumped sirv to 3.0.2 to fix security alert
#673
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Member
|
Could you sign the CLA? |
|
sirv 3.x requires node 18+, while webpack-bundle-analyzer supports node 16+ right now. So this requires dropping support for Node 16 first |
Any reason to continue to support Node 16 anymore? Node 16 is no longer supported (reached EOL in 2023) |
Member
|
No reasons, we can drop it |
|
@Billson7 - need your signature (please) |
Member
|
Node.js version less than 20 dropped #676 |
|
@valscion - still need to bump sirv version - would you like another PR for that? |
Member
|
Ah sorry I just deleted obsolete master branch, didn't think it would close this PR. Feel free to open a new PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #672
Alert: https://security.snyk.io/vuln/SNYK-JS-SIRV-12558119