Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add Node.js v23 #1978

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ci: add Node.js v23 #1978

wants to merge 1 commit into from

Conversation

snitin315
Copy link
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • documentation update
  • typo fix
  • metadata update

Motivation / Use-Case

Run tests on Node.js v23

Breaking Changes

No

Additional Info

No

Copy link

codecov bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.75%. Comparing base (7c800d5) to head (d9f746b).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1978   +/-   ##
=======================================
  Coverage   71.75%   71.75%           
=======================================
  Files          13       13           
  Lines         871      871           
  Branches      252      252           
=======================================
  Hits          625      625           
  Misses        200      200           
  Partials       46       46           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@snitin315
Copy link
Member Author

Failing on windows - node v23

@alexander-akait
Copy link
Member

Looks like fastify is broken on v23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants