Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add node 16 on ci #3378

Merged
merged 6 commits into from
Jun 7, 2021
Merged

fix: add node 16 on ci #3378

merged 6 commits into from
Jun 7, 2021

Conversation

anshumanv
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

no

Motivation / Use-Case

run tests on more node versions

Breaking Changes

no

Additional Info

@codecov
Copy link

codecov bot commented Jun 2, 2021

Codecov Report

Merging #3378 (17be714) into master (c0a0228) will decrease coverage by 0.22%.
The diff coverage is n/a.

❗ Current head 17be714 differs from pull request most recent head 6910397. Consider uploading reports for the commit 6910397 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3378      +/-   ##
==========================================
- Coverage   95.72%   95.49%   -0.23%     
==========================================
  Files          33       33              
  Lines        1309     1309              
  Branches      388      388              
==========================================
- Hits         1253     1250       -3     
- Misses         52       55       +3     
  Partials        4        4              
Impacted Files Coverage Δ
lib/utils/DevServerPlugin.js 94.44% <0.00%> (-2.78%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0a0228...6910397. Read the comment docs.

@anshumanv anshumanv changed the title fix: add more node on ci fix: add node 16 on ci Jun 2, 2021
alexander-akait
alexander-akait previously approved these changes Jun 2, 2021
@anshumanv
Copy link
Member Author

some new warnings in node 16 so snapshot failing, maybe serialize warnings

@anshumanv anshumanv closed this Jun 5, 2021
@anshumanv anshumanv reopened this Jun 5, 2021
@alexander-akait alexander-akait merged commit 84bd080 into master Jun 7, 2021
@alexander-akait alexander-akait deleted the node-ci branch June 7, 2021 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants