Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clarification in usage about hostname used #771

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

benoit74
Copy link
Contributor

@benoit74 benoit74 commented Feb 14, 2025

@tw4l @ikreymer this is ready for review, mostly minor change but we've had the question so better to clarify for everyone

@ikreymer
Copy link
Member

This is actually the container name, not the machine hostname! We don't have a way to access the machine hostname, just using os.hostname() which is the hostname of the container.

@benoit74 benoit74 force-pushed the small_doc_clarification branch from 0fed370 to e5e8933 Compare February 21, 2025 07:45
@benoit74
Copy link
Contributor Author

Indeed, I clarified it a bit further

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants